Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f771dce authored by Seth Moore's avatar Seth Moore
Browse files

Don't log stacks for exceptions recieved from binder 

The stacks for these exceptions are not helpful, as they just show
binder internals and spew noise into the logs.

Test: Manual
Change-Id: Ib3aae63b1f31a0ebbcbeaf7519bcd65b6903ab2c
parent db93b81c

services/core/java/com/android/server/security/rkp/RemoteProvisioningRegistration.java

+4 −2
Original line number Diff line number Diff line
@@ -70,12 +70,14 @@ final class RemoteProvisioningRegistration extends IRegistration.Stub { 
                Log.i(TAG, "Operation cancelled for client " + mCallback.hashCode());

                wrapCallback(mCallback::onCancel);

            } else if (e instanceof RkpProxyException) {

                Log.e(TAG, "RKP error fetching key for client " + mCallback.hashCode(), e);

                Log.e(TAG, "RKP error fetching key for client " + mCallback.hashCode() + ": "

                        + e.getMessage());

                RkpProxyException rkpException = (RkpProxyException) e;

                wrapCallback(() -> mCallback.onError(toGetKeyError(rkpException),

                        e.getMessage()));

            } else {

                Log.e(TAG, "Error fetching key for client " + mCallback.hashCode(), e);

                Log.e(TAG, "Unknown error fetching key for client " + mCallback.hashCode() + ": "

                        + e.getMessage());

                wrapCallback(() -> mCallback.onError(IGetKeyCallback.ErrorCode.ERROR_UNKNOWN,

                        e.getMessage()));

            }