Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f1654bc authored by Peter Kalauskas's avatar Peter Kalauskas
Browse files

Remove jank tracker from back panel 

This fixes the following crash:

FATAL EXCEPTION: main
Process: com.android.systemui.tests, PID: 4072
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.Handler.post(java.lang.Runnable)' on a null object reference
       at com.android.internal.jank.InteractionJankMonitor.postEventLogToWorkerThread(InteractionJankMonitor.java:598)
       at com.android.internal.jank.InteractionJankMonitor.end(InteractionJankMonitor.java:383)
       at com.android.systemui.navigationbar.gestural.BackPanelController.updateArrowState(BackPanelController.kt:892)
       at com.android.systemui.navigationbar.gestural.BackPanelController.updateArrowState$default(BackPanelController.kt:880)
       at com.android.systemui.navigationbar.gestural.BackPanelController$onEndSetGoneStateListener$1.run(BackPanelController.kt:243)
       at android.os.Handler.handleCallback(Handler.java:959)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loopOnce(Looper.java:232)
       at android.os.Looper.loop(Looper.java:317)
       at android.app.ActivityThread.main(ActivityThread.java:8524)
       at java.lang.reflect.Method.invoke(Native Method)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

Bug: 304583132
Bug: 304582856
Flag: ACONFIG com.android.systemui.edge_back_gesture_handler_thread DISABLED
Change-Id: Ib1e4c56111a908586b17b7225371317121909fce
parent 703fd3da

packages/SystemUI/src/com/android/systemui/navigationbar/gestural/BackPanelController.kt

+0 −11
Original line number Diff line number Diff line
@@ -371,7 +371,6 @@ internal constructor( 
                // Receiving a CANCEL implies that something else intercepted

                // the gesture, i.e., the user did not cancel their gesture.

                // Therefore, disappear immediately, with minimum fanfare.

                interactionJankMonitor.cancel(CUJ_BACK_PANEL_ARROW)

                updateArrowState(GestureState.GONE)

                velocityTracker = null

            }
@@ -883,16 +882,6 @@ internal constructor( 
        previousState = currentState

        currentState = newState



        // First, update the jank tracker

        when (currentState) {

            GestureState.ENTRY -> {

                interactionJankMonitor.cancel(CUJ_BACK_PANEL_ARROW)

                interactionJankMonitor.begin(mView, CUJ_BACK_PANEL_ARROW)

            }

            GestureState.GONE -> interactionJankMonitor.end(CUJ_BACK_PANEL_ARROW)

            else -> {}

        }



        when (currentState) {

            GestureState.CANCELLED -> {

                backCallback.cancelBack()