Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 0ed52ac4 authored by Yi-Yo Chiang's avatar Yi-Yo Chiang Committed by Eric Biggers
Browse files

locksettings: Don't use AIDL V1 weaver

V1 and V2 reports IWeaver.read() errors differently.
V1 throws ServiceSpecificException wrapping an error code.
V2 returns the error code in the output parcel.

The current client code expects the weaver HAL to be V2 or newer,
however it doesn't check if the actual service version is V2 or not.
If the service is V1, then IWeaver.read() errors would become
unhandled exception, crashing the system_server.
Since Weaver AIDL V1 is broken and should never be used, don't use
Weaver AIDL V1 services. This fixes a regression in Android 14 where
AIDL V1 started being used when available.

Bug: 296984182
Bug: 296512452
Test: Boot on old (tm) vendor
Change-Id: I32306fb8473c655e68d89d63a1e4f00c8bb5d61f
Merged-In: I32306fb8473c655e68d89d63a1e4f00c8bb5d61f
(cherry picked from commit 048aaf42)
parent 5f8125f5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment