Removed ViewTreeObserver null checks (0e7d652d) · Commits · e / os / android_frameworks_base

core/java/android/webkit/WebView.java

+18 −20

Original line number	Diff line number	Diff line
		@@ -5028,7 +5028,6 @@ public class WebView extends AbsoluteLayout
		super.onAttachedToWindow();
		if (hasWindowFocus()) setActive(true);
		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		if (mGlobalLayoutListener == null) {
		mGlobalLayoutListener = new InnerGlobalLayoutListener();
		treeObserver.addOnGlobalLayoutListener(mGlobalLayoutListener);
		@@ -5037,7 +5036,6 @@ public class WebView extends AbsoluteLayout
		mScrollChangedListener = new InnerScrollChangedListener();
		treeObserver.addOnScrollChangedListener(mScrollChangedListener);
		}
		}

		addAccessibilityApisToJavaScript();
		}
		@@ -5049,7 +5047,6 @@ public class WebView extends AbsoluteLayout
		if (hasWindowFocus()) setActive(false);

		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		if (mGlobalLayoutListener != null) {
		treeObserver.removeGlobalOnLayoutListener(mGlobalLayoutListener);
		mGlobalLayoutListener = null;
		@@ -5058,7 +5055,6 @@ public class WebView extends AbsoluteLayout
		treeObserver.removeOnScrollChangedListener(mScrollChangedListener);
		mScrollChangedListener = null;
		}
		}

		removeAccessibilityApisFromJavaScript();

		@@ -5091,8 +5087,7 @@ public class WebView extends AbsoluteLayout

		/**
		* @deprecated WebView should not have implemented
		* ViewTreeObserver.OnGlobalFocusChangeListener. This method
		* does nothing now.
		* ViewTreeObserver.OnGlobalFocusChangeListener. This method does nothing now.
		*/
		@Deprecated
		public void onGlobalFocusChanged(View oldFocus, View newFocus) {
		@@ -7725,6 +7720,7 @@ public class WebView extends AbsoluteLayout
		int mEnabled;
		int mId;

		@Override
		public String toString() {
		return mString;
		}
		@@ -7878,6 +7874,7 @@ public class WebView extends AbsoluteLayout
		mAdapter = a;
		}

		@Override
		public void onChanged() {
		// The filter may have changed which item is checked. Find the
		// item that the ListView thinks is checked.
		@@ -8193,6 +8190,7 @@ public class WebView extends AbsoluteLayout
		* zero to make the view transparent.
		* @param color the ARGB color described by Color.java
		*/
		@Override
		public void setBackgroundColor(int color) {
		mBackgroundColor = color;
		mWebViewCore.sendMessage(EventHub.SET_BACKGROUND_COLOR, color);

core/java/android/widget/AbsListView.java

+7 −11

Original line number	Diff line number	Diff line
		@@ -2267,12 +2267,10 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
		super.onAttachedToWindow();

		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		treeObserver.addOnTouchModeChangeListener(this);
		if (mTextFilterEnabled && mPopup != null && !mGlobalLayoutListenerAddedFilter) {
		treeObserver.addOnGlobalLayoutListener(this);
		}
		}

		if (mAdapter != null && mDataSetObserver == null) {
		mDataSetObserver = new AdapterDataSetObserver();
		@@ -2296,13 +2294,11 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te
		mRecycler.clear();

		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		treeObserver.removeOnTouchModeChangeListener(this);
		if (mTextFilterEnabled && mPopup != null) {
		treeObserver.removeGlobalOnLayoutListener(this);
		mGlobalLayoutListenerAddedFilter = false;
		}
		}

		if (mAdapter != null) {
		mAdapter.unregisterDataSetObserver(mDataSetObserver);

core/java/android/widget/TabHost.java

+2 −6

Original line number	Diff line number	Diff line
		@@ -183,19 +183,15 @@ mTabHost.addTab(TAB_TAG_1, "Hello, world!", "Tab 1");
		protected void onAttachedToWindow() {
		super.onAttachedToWindow();
		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		treeObserver.addOnTouchModeChangeListener(this);
		}
		}

		@Override
		protected void onDetachedFromWindow() {
		super.onDetachedFromWindow();
		final ViewTreeObserver treeObserver = getViewTreeObserver();
		if (treeObserver != null) {
		treeObserver.removeOnTouchModeChangeListener(this);
		}
		}

		/**
		* {@inheritDoc}