Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e3e6f82 authored Jul 11, 2017 by Philip P. Moltmann

Handle failures in validators

Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
          --test=android.autofillservice.cts.ValidatorTest
Bug: 62534917

Change-Id: I3aad06cd2e8b6caf7238e420727aca0cb3703bc5

parent 796b7a56

api/current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -37059,7 +37059,7 @@ package android.service.autofill {
		method public android.service.autofill.ImageTransformation build();
		}

		public final class LuhnChecksumValidator implements android.os.Parcelable {
		public final class LuhnChecksumValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public LuhnChecksumValidator(android.view.autofill.AutofillId...);
		method public int describeContents();
		method public void writeToParcel(android.os.Parcel, int);
		@@ -37105,7 +37105,7 @@ package android.service.autofill {
		field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;
		}

		public final class SimpleRegexValidator implements android.os.Parcelable {
		public final class SimpleRegexValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public SimpleRegexValidator(android.view.autofill.AutofillId, java.lang.String);
		method public int describeContents();
		method public void writeToParcel(android.os.Parcel, int);

api/system-current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -40140,7 +40140,7 @@ package android.service.autofill {
		method public android.service.autofill.ImageTransformation build();
		}

		public final class LuhnChecksumValidator implements android.os.Parcelable {
		public final class LuhnChecksumValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public LuhnChecksumValidator(android.view.autofill.AutofillId...);
		method public int describeContents();
		method public void writeToParcel(android.os.Parcel, int);
		@@ -40186,7 +40186,7 @@ package android.service.autofill {
		field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;
		}

		public final class SimpleRegexValidator implements android.os.Parcelable {
		public final class SimpleRegexValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public SimpleRegexValidator(android.view.autofill.AutofillId, java.lang.String);
		method public int describeContents();
		method public void writeToParcel(android.os.Parcel, int);

api/test-current.txt

+2 −2

Original line number	Diff line number	Diff line
		@@ -37234,7 +37234,7 @@ package android.service.autofill {
		method public android.service.autofill.ImageTransformation build();
		}

		public final class LuhnChecksumValidator implements android.os.Parcelable {
		public final class LuhnChecksumValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public LuhnChecksumValidator(android.view.autofill.AutofillId...);
		method public int describeContents();
		method public boolean isValid(android.service.autofill.ValueFinder);
		@@ -37281,7 +37281,7 @@ package android.service.autofill {
		field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;
		}

		public final class SimpleRegexValidator implements android.os.Parcelable {
		public final class SimpleRegexValidator implements android.os.Parcelable android.service.autofill.Validator {
		ctor public SimpleRegexValidator(android.view.autofill.AutofillId, java.lang.String);
		method public int describeContents();
		method public void writeToParcel(android.os.Parcel, int);

core/java/android/service/autofill/InternalValidator.java

+6 −1

Original line number	Diff line number	Diff line
		@@ -18,7 +18,12 @@ package android.service.autofill;
		import android.annotation.NonNull;
		import android.os.Parcelable;

		/** @hide */
		/**
		* Superclass of all validators the system understands. As this is not public all public subclasses
		* have to implement {@link Validator} again.
		*
		* @hide
		*/
		public abstract class InternalValidator implements Validator, Parcelable {

		/**

core/java/android/service/autofill/LuhnChecksumValidator.java

+2 −1

Original line number	Diff line number	Diff line
		@@ -33,7 +33,8 @@ import com.android.internal.util.Preconditions;
		*
		* <p>See {@link SaveInfo.Builder#setValidator(Validator)} for examples.
		*/
		public final class LuhnChecksumValidator extends InternalValidator implements Parcelable {
		public final class LuhnChecksumValidator extends InternalValidator implements Validator,
		Parcelable {
		private static final String TAG = "LuhnChecksumValidator";

		private final AutofillId[] mIds;