Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0dabecd8 authored by Chavi Weingarten's avatar Chavi Weingarten
Browse files

Wrap Transaction JNI object in ScopedLocalRef 

Ensure the Transaction object is cleared when out of scope.

Test: SurfaceSyncGroupContinuousTest
Bug: 295847414
Change-Id: Ie06c715c4a6855f8c9134b7bd6a53ca2de6d21b7
parent 779bb8ef

core/jni/android_graphics_BLASTBufferQueue.cpp

+6 −3
Original line number Diff line number Diff line
@@ -139,10 +139,13 @@ static bool nativeSyncNextTransaction(JNIEnv* env, jclass clazz, jlong ptr, jobj 
    return queue->syncNextTransaction(

            [globalCallbackRef](SurfaceComposerClient::Transaction* t) {

                JNIEnv* env = getenv(globalCallbackRef->vm());

                env->CallVoidMethod(globalCallbackRef->object(), gTransactionConsumer.accept,

                ScopedLocalRef<jobject>

                        transactionObject(env,

                                          env->NewObject(gTransactionClassInfo.clazz,

                                                         gTransactionClassInfo.ctor,

                                                         reinterpret_cast<jlong>(t)));

                env->CallVoidMethod(globalCallbackRef->object(), gTransactionConsumer.accept,

                                    transactionObject.get());

            },

            acquireSingleBuffer);

}