Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d16281a authored by Erik Kline's avatar Erik Kline Committed by Android (Google) Code Review
Browse files

Merge "Add a test that Network#getNetworkHandle() behaves sanely." into mnc-dev

parents 100e1c92 e1a6cf2c
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -378,6 +378,9 @@ public class Network implements Parcelable {
        //
        // The HANDLE_MAGIC value MUST be kept in sync with the corresponding
        // value in the native/android/net.c NDK implementation.
        if (netId == 0) {
            return 0L;  // make this zero condition obvious for debugging
        }
        final long HANDLE_MAGIC = 0xfacade;
        return (((long) netId) << 32) | HANDLE_MAGIC;
    }
+50 −0
Original line number Diff line number Diff line
@@ -16,11 +16,14 @@

package android.net;

import static android.test.MoreAsserts.assertNotEqual;

import android.net.LocalServerSocket;
import android.net.LocalSocket;
import android.net.LocalSocketAddress;
import android.net.Network;
import android.test.suitebuilder.annotation.SmallTest;

import java.io.File;
import java.io.FileDescriptor;
import java.io.FileInputStream;
@@ -29,6 +32,7 @@ import java.net.DatagramSocket;
import java.net.InetAddress;
import java.net.Inet6Address;
import java.net.SocketException;

import junit.framework.TestCase;

public class NetworkTest extends TestCase {
@@ -93,4 +97,50 @@ public class NetworkTest extends TestCase {
            fail("SocketException not thrown");
        } catch (SocketException expected) {}
    }

    @SmallTest
    public void testZeroIsObviousForDebugging() {
        Network zero = new Network(0);
        assertEquals(0, zero.hashCode());
        assertEquals(0, zero.getNetworkHandle());
        assertEquals("0", zero.toString());
    }

    @SmallTest
    public void testGetNetworkHandle() {
        Network one = new Network(1);
        Network two = new Network(2);
        Network three = new Network(3);

        // None of the hashcodes are zero.
        assertNotEqual(0, one.hashCode());
        assertNotEqual(0, two.hashCode());
        assertNotEqual(0, three.hashCode());

        // All the hashcodes are distinct.
        assertNotEqual(one.hashCode(), two.hashCode());
        assertNotEqual(one.hashCode(), three.hashCode());
        assertNotEqual(two.hashCode(), three.hashCode());

        // None of the handles are zero.
        assertNotEqual(0, one.getNetworkHandle());
        assertNotEqual(0, two.getNetworkHandle());
        assertNotEqual(0, three.getNetworkHandle());

        // All the handles are distinct.
        assertNotEqual(one.getNetworkHandle(), two.getNetworkHandle());
        assertNotEqual(one.getNetworkHandle(), three.getNetworkHandle());
        assertNotEqual(two.getNetworkHandle(), three.getNetworkHandle());

        // The handles are not equal to the hashcodes.
        assertNotEqual(one.hashCode(), one.getNetworkHandle());
        assertNotEqual(two.hashCode(), two.getNetworkHandle());
        assertNotEqual(three.hashCode(), three.getNetworkHandle());

        // Adjust as necessary to test an implementation's specific constants.
        // When running with runtest, "adb logcat -s TestRunner" can be useful.
        assertEquals(4311403230L, one.getNetworkHandle());
        assertEquals(8606370526L, two.getNetworkHandle());
        assertEquals(12901337822L, three.getNetworkHandle());
    }
}