Merge "Fix deadlock when using PackageManagerLocal while holding mLock."

    @Deprecated

    @NonNull

    public Computer snapshotComputer(boolean allowLiveComputer) {

        var isHoldingPackageLock = Thread.holdsLock(mLock);

        if (allowLiveComputer) {

            if (Thread.holdsLock(mLock)) {

            if (isHoldingPackageLock) {

                // If the current thread holds mLock then it may have modified state but not

                // yet invalidated the snapshot.  Always give the thread the live computer.

                return mLiveComputer;

            return oldSnapshot.use();

        }

        if (isHoldingPackageLock) {

            // If the current thread holds mLock then it already has exclusive write access to the

            // two snapshot fields, and we can just go ahead and rebuild the snapshot.

            @SuppressWarnings("GuardedBy")

            var newSnapshot = rebuildSnapshot(oldSnapshot, pendingVersion);

            sSnapshot.set(newSnapshot);

            return newSnapshot.use();

        }

        synchronized (mSnapshotLock) {

            // Re-capture pending version in case a new invalidation occurred since last check

            var rebuildSnapshot = sSnapshot.get();

                // Fetch version one last time to ensure that the rebuilt snapshot matches

                // the latest invalidation, which could have come in between entering the

                // SnapshotLock and mLock sync blocks.

                rebuildSnapshot = sSnapshot.get();

                rebuildVersion = sSnapshotPendingVersion.get();

                if (rebuildSnapshot != null && rebuildSnapshot.getVersion() == rebuildVersion) {

                    return rebuildSnapshot.use();

                }

                // Build the snapshot for this version

                var newSnapshot = rebuildSnapshot(rebuildSnapshot, rebuildVersion);

        }

    }

    @GuardedBy({ "mLock", "mSnapshotLock"})

    @GuardedBy("mLock")

    private Computer rebuildSnapshot(@Nullable Computer oldSnapshot, int newVersion) {

        var now = SystemClock.currentTimeMicro();

        var hits = oldSnapshot == null ? -1 : oldSnapshot.getUsed();