Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c046390 authored by Ricardo Cerqueira's avatar Ricardo Cerqueira
Browse files

telephony: SignalStrengh: Don't calculate a LTE snr if the srq is invalid 

If the previous values are invalid and signal quality is -1, chances are there's
no LTE signal at all, so don't calculate the SNR and mark it invalid as well.

This fixes the strength indicator in GSM devices where it was being skewed
by the ghost LTE value

Change-Id: I070573401c141aa99941a332ee256246697abb90
parent 80092c5b

telephony/java/android/telephony/SignalStrength.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -342,7 +342,7 @@ public class SignalStrength implements Parcelable { 
        mLteSignalStrength = (mLteSignalStrength >= 0) ? mLteSignalStrength : 99;

        mLteSignalStrength = (mLteSignalStrength >= 0) ? mLteSignalStrength : 99;

        mLteRsrp = ((mLteRsrp >= 44) && (mLteRsrp <= 140)) ? -mLteRsrp : SignalStrength.INVALID;

        mLteRsrp = ((mLteRsrp >= 44) && (mLteRsrp <= 140)) ? -mLteRsrp : SignalStrength.INVALID;

        mLteRsrq = ((mLteRsrq >= 3) && (mLteRsrq <= 20)) ? -mLteRsrq : SignalStrength.INVALID;

        mLteRsrq = ((mLteRsrq >= 3) && (mLteRsrq <= 20)) ? -mLteRsrq : SignalStrength.INVALID;

        mLteRssnr = ((mLteRssnr >= -200) && (mLteRssnr <= 300)) ? mLteRssnr

        mLteRssnr = ((mLteRssnr >= -200) && (mLteRssnr <= 300) && !(mLteRsrq == SignalStrength.INVALID && mLteRssnr == -1)) ? mLteRssnr

                : SignalStrength.INVALID;

                : SignalStrength.INVALID;

        // Cqi no change

        // Cqi no change

        if (DBG) log("Signal after validate=" + this);

        if (DBG) log("Signal after validate=" + this);