Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bf52557 authored by Fabian Kozynski's avatar Fabian Kozynski
Browse files

Change default intent for AlarmTile 

As most times, users would want to turn on an existing alarm, and
there's a button right there to add a new alarm, this intent is a better
landing point as default.

Test: atest AlarmTileTest
Fixes: 200710299
Change-Id: I97e929aa471fa45587104e82e592f87408a23e63
parent fcf06e22

packages/SystemUI/src/com/android/systemui/qs/tiles/AlarmTile.kt

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ class AlarmTile @Inject constructor( 
    private var lastAlarmInfo: AlarmManager.AlarmClockInfo? = null

    private val icon = ResourceIcon.get(R.drawable.ic_alarm)

    @VisibleForTesting

    internal val defaultIntent = Intent(AlarmClock.ACTION_SET_ALARM)

    internal val defaultIntent = Intent(AlarmClock.ACTION_SHOW_ALARMS)

    private val callback = NextAlarmController.NextAlarmChangeCallback { nextAlarm ->

        lastAlarmInfo = nextAlarm

        refreshState()

packages/SystemUI/tests/src/com/android/systemui/qs/tiles/AlarmTileTest.kt

+6 −0
Original line number Diff line number Diff line
@@ -3,6 +3,7 @@ package com.android.systemui.qs.tiles 
import android.app.AlarmManager

import android.app.PendingIntent

import android.os.Handler

import android.provider.AlarmClock

import android.service.quicksettings.Tile

import android.testing.AndroidTestingRunner

import android.testing.TestableLooper
@@ -97,6 +98,11 @@ class AlarmTileTest : SysuiTestCase() { 
        assertThat(tile.state.handlesLongClick).isFalse()

    }



    @Test

    fun testDefaultIntentShowAlarms() {

        assertThat(tile.defaultIntent.action).isEqualTo(AlarmClock.ACTION_SHOW_ALARMS)

    }



    @Test

    fun testInactiveByDefault() {

        assertThat(tile.state.state).isEqualTo(Tile.STATE_INACTIVE)