Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0bacf4f4 authored by Rambo Wang's avatar Rambo Wang
Browse files

Update javadoc of TM#getDataNetworkType to align with implementation 

Javadoc of TelephonyManager#getDataNetworkType says if the
TelephonyManager object is not created with createForSubscriptionId,
then applies to SubscriptionManager#getDefaultDataSubscriptionId().

But the actual implementation applies to
SubscriptionManager#getActiveDataSubscriptionId() instead. While they
are not always the same (e.g. when opptunistic network is active), the
implementation is more accurate than the javadoc.

Bug: 144803512
Test: make docs
Change-Id: I7db32a9a99dd5d7f7c32b6b33f3d5f7bd09a0e02
parent 94a4cdd4

telephony/java/android/telephony/TelephonyManager.java

+6 −1
Original line number Diff line number Diff line
@@ -2932,7 +2932,12 @@ public class TelephonyManager { 
     * currently in use on the device for data transmission.

     *

     * If this object has been created with {@link #createForSubscriptionId}, applies to the given

     * subId. Otherwise, applies to {@link SubscriptionManager#getDefaultDataSubscriptionId()}

     * subId. Otherwise, applies to {@link SubscriptionManager#getActiveDataSubscriptionId()}.

     *

     * Note: Before {@link SubscriptionManager#getActiveDataSubscriptionId()} was introduced in API

     * level 30, it was applied to {@link SubscriptionManager#getDefaultDataSubscriptionId()} which

     * may be different now from {@link SubscriptionManager#getActiveDataSubscriptionId()}, e.g.

     * when opportunistic network is providing cellular internet connection to the user.

     *

     * <p>Requires Permission: {@link android.Manifest.permission#READ_PHONE_STATE READ_PHONE_STATE}

     * or that the calling app has carrier privileges (see {@link #hasCarrierPrivileges}).