Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b6a8961 authored by András Kurucz's avatar András Kurucz
Browse files

[Flexiglass] Always include the FooterView in the StackScrollAlgorithm 

SSA was skipping to include the FooterView to its visible children while
it was displayed together with the empty view, or if it was the first
child.
This condition was there to skip updates on the footer while it was in a
transitional state, but it caused a more severe bug on Dual Shade, where
it is displayed with the EmptyShadeView by default. By skipping the
FooterView update we left it in a stale position, which was coming from
a previous shade state.

Fixes: 415969173
Test: Check the empty state of the Notifications overlay
Flag: com.android.systemui.scene_container
Change-Id: I5cb5831d8f81c98e27f7f654b813e25dc6d96d47
parent 1f9783b7

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/StackScrollAlgorithm.java

+2 −3
Original line number Diff line number Diff line
@@ -474,12 +474,11 @@ public class StackScrollAlgorithm { 
                if (v instanceof EmptyShadeView) {

                    emptyShadeVisible = true;

                }

                if (v instanceof FooterView footerView) {

                if (!SceneContainerFlag.isEnabled() && v instanceof FooterView footerView) {

                    if (emptyShadeVisible || notGoneIndex == 0) {

                        // if the empty shade is visible or the footer is the first visible

                        // view, we're in a transitory state so let's leave the footer alone.

                        if (Flags.notificationsFooterVisibilityFix()

                                && !SceneContainerFlag.isEnabled()) {

                        if (Flags.notificationsFooterVisibilityFix()) {

                            // ...except for the hidden state, to prevent it from flashing on

                            // the screen (this piece is copied from updateChild, and is not

                            // necessary in flexiglass).