Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ae4d976 authored by Glenn Kasten's avatar Glenn Kasten
Browse files

Declare methods in binder opcode order 

This makes it easier to compare interface and implementation.

Change-Id: Ie060e43dec348902abcf40f5a610cec639d6d0d3
parent 0f73d75d

services/audioflinger/AudioFlinger.cpp

+8 −8
Original line number Diff line number Diff line
@@ -4104,6 +4104,10 @@ AudioFlinger::TrackHandle::~TrackHandle() { 
    mTrack->destroy();

}



sp<IMemory> AudioFlinger::TrackHandle::getCblk() const {

    return mTrack->getCblk();

}



status_t AudioFlinger::TrackHandle::start() {

    return mTrack->start();

}
@@ -4124,10 +4128,6 @@ void AudioFlinger::TrackHandle::pause() { 
    mTrack->pause();

}



sp<IMemory> AudioFlinger::TrackHandle::getCblk() const {

    return mTrack->getCblk();

}



status_t AudioFlinger::TrackHandle::attachAuxEffect(int EffectId)

{

    return mTrack->attachAuxEffect(EffectId);
@@ -4234,6 +4234,10 @@ AudioFlinger::RecordHandle::~RecordHandle() { 
    stop();

}



sp<IMemory> AudioFlinger::RecordHandle::getCblk() const {

    return mRecordTrack->getCblk();

}



status_t AudioFlinger::RecordHandle::start() {

    ALOGV("RecordHandle::start()");

    return mRecordTrack->start();
@@ -4244,10 +4248,6 @@ void AudioFlinger::RecordHandle::stop() { 
    mRecordTrack->stop();

}



sp<IMemory> AudioFlinger::RecordHandle::getCblk() const {

    return mRecordTrack->getCblk();

}



status_t AudioFlinger::RecordHandle::onTransact(

    uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags)

{

services/audioflinger/AudioFlinger.h

+2 −2
Original line number Diff line number Diff line
@@ -908,12 +908,12 @@ private: 
    public:

                            TrackHandle(const sp<PlaybackThread::Track>& track);

        virtual             ~TrackHandle();

        virtual sp<IMemory> getCblk() const;

        virtual status_t    start();

        virtual void        stop();

        virtual void        flush();

        virtual void        mute(bool);

        virtual void        pause();

        virtual sp<IMemory> getCblk() const;

        virtual status_t    attachAuxEffect(int effectId);

        virtual status_t onTransact(

            uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags);
@@ -1031,9 +1031,9 @@ private: 
    public:

        RecordHandle(const sp<RecordThread::RecordTrack>& recordTrack);

        virtual             ~RecordHandle();

        virtual sp<IMemory> getCblk() const;

        virtual status_t    start();

        virtual void        stop();

        virtual sp<IMemory> getCblk() const;

        virtual status_t onTransact(

            uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags);

    private: