Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ae49d30 authored by Ryan Mitchell's avatar Ryan Mitchell
Browse files

Prevent Theme#dump from restricting minimum severity 

After Theme#dump is used, all logs with a lower severity than "info"
were not being shown. Removing base::ScopedLogSeverity fixes this
issue. ScopedLogSeverity does not have any purpose in these code blocks
since the dump command is doing the theme logging at a fixed severity.

Bug: 175070283
Test: use debugger to invoke dump and verify that it does not limit
      minimum severity
Change-Id: I4564d119b3672398c6b1d11cd946080cca458218
parent 67eca1c2

libs/androidfw/AssetManager2.cpp

+0 −3
Original line number Diff line number Diff line
@@ -226,8 +226,6 @@ void AssetManager2::BuildDynamicRefTable() { 
}



void AssetManager2::DumpToLog() const {

  base::ScopedLogSeverity _log(base::INFO);



  LOG(INFO) << base::StringPrintf("AssetManager2(this=%p)", this);



  std::string list;
@@ -1721,7 +1719,6 @@ base::expected<std::monostate, IOError> Theme::SetTo(const Theme& o) { 
}



void Theme::Dump() const {

  base::ScopedLogSeverity _log(base::INFO);

  LOG(INFO) << base::StringPrintf("Theme(this=%p, AssetManager2=%p)", this, asset_manager_);



  for (int p = 0; p < packages_.size(); p++) {