Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a6d6154 authored by Ben Lin's avatar Ben Lin
Browse files

PiP: Animate resize even if the bounds are the same. 

On PiP resize animation, we have callbacks that show menu, set PiP to
the correct state, etc. Even if the bounds are the same (which is
possible if the user has resized the largest possible bound and taps on
it), we should still just let the animator do its job so all the
post-animation callbacks are correctly executed.

Bug: 158859217
Test: Resize PIP to max, wait for a new video to come in (current video
finishes playing), tap on PIP - menu displays

Change-Id: I37e669918434b9cfa1cd24356170ddb760092b00
parent 7775314f

packages/SystemUI/src/com/android/systemui/pip/phone/PipMotionHelper.java

+5 −4
Original line number Diff line number Diff line
@@ -491,11 +491,12 @@ public class PipMotionHelper implements PipAppOpsListener.Callback, 
            Log.d(TAG, "resizeAndAnimatePipUnchecked: toBounds=" + toBounds

                    + " duration=" + duration + " callers=\n" + Debug.getCallers(5, "    "));

        }

        if (!toBounds.equals(mBounds)) {



        // Intentionally resize here even if the current bounds match the destination bounds.

        // This is so all the proper callbacks are performed.

        mPipTaskOrganizer.scheduleAnimateResizePip(toBounds, duration, mUpdateBoundsCallback);

        setAnimatingToBounds(toBounds);

    }

    }



    /**

     * Returns a MagnetizedObject wrapper for PIP's animated bounds. This is provided to the