Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a646ca7 authored by Alex Buynytskyy's avatar Alex Buynytskyy
Browse files

Better test for setStorageParams. 

Using service connector - as would DataLoaders do - instead of calling
service method directly.

Bug: b/153530451
Test: atest IncrementalServiceTest
Change-Id: I43b9ffa235204b073465c19ab32c0435d2dfe755
parent edb826c2

services/incremental/test/IncrementalServiceTest.cpp

+13 −4
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ public: 
                                          bool* _aidl_return) {

        mId = mountId;

        mListener = listener;

        mServiceConnector = control.service;

        *_aidl_return = true;

        return binder::Status::ok();

    }
@@ -166,9 +167,17 @@ public: 
        mListener->onStatusChanged(mId, IDataLoaderStatusListener::DATA_LOADER_CREATED);

    }



    int32_t setStorageParams(bool enableReadLogs) {

        int32_t result = -1;

        EXPECT_NE(mServiceConnector.get(), nullptr);

        EXPECT_TRUE(mServiceConnector->setStorageParams(enableReadLogs, &result).isOk());

        return result;

    }



private:

    int mId;

    sp<IDataLoaderStatusListener> mListener;

    sp<IIncrementalServiceConnector> mServiceConnector;

    sp<IDataLoader> mDataLoader = sp<IDataLoader>(new FakeDataLoader());

};
@@ -453,7 +462,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccess) { 
            mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},

                                               IncrementalService::CreateOptions::CreateNew);

    ASSERT_GE(storageId, 0);

    ASSERT_GE(mIncrementalService->setStorageParams(storageId, true), 0);

    ASSERT_GE(mDataLoaderManager->setStorageParams(true), 0);

}



TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccessAndPermissionChanged) {
@@ -480,7 +489,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsSuccessAndPermissionChang 
            mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},

                                               IncrementalService::CreateOptions::CreateNew);

    ASSERT_GE(storageId, 0);

    ASSERT_GE(mIncrementalService->setStorageParams(storageId, true), 0);

    ASSERT_GE(mDataLoaderManager->setStorageParams(true), 0);

    ASSERT_NE(nullptr, mAppOpsManager->mStoredCallback.get());

    mAppOpsManager->mStoredCallback->opChanged(0, {});

}
@@ -503,7 +512,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsCheckPermissionFails) { 
            mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},

                                               IncrementalService::CreateOptions::CreateNew);

    ASSERT_GE(storageId, 0);

    ASSERT_LT(mIncrementalService->setStorageParams(storageId, true), 0);

    ASSERT_LT(mDataLoaderManager->setStorageParams(true), 0);

}



TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsFails) {
@@ -526,7 +535,7 @@ TEST_F(IncrementalServiceTest, testSetIncFsMountOptionsFails) { 
            mIncrementalService->createStorage(tempDir.path, std::move(mDataLoaderParcel), {},

                                               IncrementalService::CreateOptions::CreateNew);

    ASSERT_GE(storageId, 0);

    ASSERT_LT(mIncrementalService->setStorageParams(storageId, true), 0);

    ASSERT_LT(mDataLoaderManager->setStorageParams(true), 0);

}



TEST_F(IncrementalServiceTest, testMakeDirectory) {