Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09ddba78 authored by Christian Göllner's avatar Christian Göllner Committed by Christian Göllner
Browse files

PanelExpansionStateManager: add new parameter for raw drag amount 

This will be needed for split-shade expansion motion. The absolute value of the expansion will be used instead of fractions.

+ refactor multiple primitive parameters into a single high-level type parameter.

Test: unit tests
Change-Id: Ia35f79ff42f29e44e4123776be30ebc33ee2aab0
Merged-In: Ia35f79ff42f29e44e4123776be30ebc33ee2aab0
parent b80800cc

packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.kt

+7 −8
Original line number Diff line number Diff line
@@ -54,12 +54,11 @@ abstract class UdfpsAnimationViewController<T : UdfpsAnimationView>( 
    private var dialogAlphaAnimator: ValueAnimator? = null

    private val dialogListener = SystemUIDialogManager.Listener { runDialogAlphaAnimator() }



    private val panelExpansionListener =

        PanelExpansionListener { fraction, expanded, tracking ->

    private val panelExpansionListener = PanelExpansionListener { event ->

        // Notification shade can be expanded but not visible (fraction: 0.0), for example

        // when a heads-up notification (HUN) is showing.

            notificationShadeVisible = expanded && fraction > 0f

            view.onExpansionChanged(fraction)

        notificationShadeVisible = event.expanded && event.fraction > 0f

        view.onExpansionChanged(event.fraction)

        updatePauseAuth()

    }

packages/SystemUI/src/com/android/systemui/biometrics/UdfpsKeyguardViewController.java

+3 −2
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ import com.android.systemui.statusbar.phone.KeyguardBouncer; 
import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager;

import com.android.systemui.statusbar.phone.SystemUIDialogManager;

import com.android.systemui.statusbar.phone.UnlockedScreenOffAnimationController;

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionChangeEvent;

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionListener;

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionStateManager;

import com.android.systemui.statusbar.policy.ConfigurationController;
@@ -491,8 +492,8 @@ public class UdfpsKeyguardViewController extends UdfpsAnimationViewController<Ud 


    private final PanelExpansionListener mPanelExpansionListener = new PanelExpansionListener() {

        @Override

        public void onPanelExpansionChanged(

                float fraction, boolean expanded, boolean tracking) {

        public void onPanelExpansionChanged(PanelExpansionChangeEvent event) {

            float fraction = event.getFraction();

            mPanelExpansionFraction =

                    mKeyguardViewManager.isBouncerInTransit() ? BouncerPanelExpansionCalculator

                            .aboutToShowBouncerProgress(fraction) : fraction;

packages/SystemUI/src/com/android/systemui/dreams/touch/BouncerSwipeTouchHandler.java

+18 −7
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ import com.android.systemui.statusbar.NotificationShadeWindowController; 
import com.android.systemui.statusbar.phone.CentralSurfaces;

import com.android.systemui.statusbar.phone.KeyguardBouncer;

import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager;

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionChangeEvent;

import com.android.wm.shell.animation.FlingAnimationUtils;



import java.util.Optional;
@@ -141,19 +142,27 @@ public class BouncerSwipeTouchHandler implements DreamTouchHandler { 
                    // bouncer. As that view's expansion shrinks, the bouncer appears. The bouncer

                    // is fully hidden at full expansion (1) and fully visible when fully collapsed

                    // (0).

                    final float dragDownAmount = e2.getY() - e1.getY();

                    final float screenTravelPercentage = Math.abs(e1.getY() - e2.getY())

                            / mCentralSurfaces.get().getDisplayHeight();

                    setPanelExpansion(mBouncerInitiallyShowing

                            ? screenTravelPercentage : 1 - screenTravelPercentage);

                            ? screenTravelPercentage : 1 - screenTravelPercentage, dragDownAmount);

                    return true;

                }

            };



    private void setPanelExpansion(float expansion) {

    private void setPanelExpansion(float expansion, float dragDownAmount) {

        mCurrentExpansion = expansion;

        mStatusBarKeyguardViewManager.onPanelExpansionChanged(mCurrentExpansion, false, true);

        PanelExpansionChangeEvent event =

                new PanelExpansionChangeEvent(

                        /* fraction= */ mCurrentExpansion,

                        /* expanded= */ false,

                        /* tracking= */ true,

                        /* dragDownPxAmount= */ dragDownAmount);

        mStatusBarKeyguardViewManager.onPanelExpansionChanged(event);

    }





    @VisibleForTesting

    public enum DreamEvent implements UiEventLogger.UiEventEnum {

        @UiEvent(doc = "The screensaver has been swiped up.")
@@ -283,12 +292,14 @@ public class BouncerSwipeTouchHandler implements DreamTouchHandler { 
        }

    }



    private ValueAnimator createExpansionAnimator(float targetExpansion) {

    private ValueAnimator createExpansionAnimator(float targetExpansion, float expansionHeight) {

        final ValueAnimator animator =

                mValueAnimatorCreator.create(mCurrentExpansion, targetExpansion);

        animator.addUpdateListener(

                animation -> {

                    setPanelExpansion((float) animation.getAnimatedValue());

                    float expansionFraction = (float) animation.getAnimatedValue();

                    float dragDownAmount = expansionFraction * expansionHeight;

                    setPanelExpansion(expansionFraction, dragDownAmount);

                });

        if (!mBouncerInitiallyShowing && targetExpansion == KeyguardBouncer.EXPANSION_VISIBLE) {

            animator.addListener(
@@ -321,8 +332,8 @@ public class BouncerSwipeTouchHandler implements DreamTouchHandler { 
        final float viewHeight = mCentralSurfaces.get().getDisplayHeight();

        final float currentHeight = viewHeight * mCurrentExpansion;

        final float targetHeight = viewHeight * expansion;



        final ValueAnimator animator = createExpansionAnimator(expansion);

        final float expansionHeight = targetHeight - currentHeight;

        final ValueAnimator animator = createExpansionAnimator(expansion, expansionHeight);

        if (expansion == KeyguardBouncer.EXPANSION_HIDDEN) {

            // Hides the bouncer, i.e., fully expands the space above the bouncer.

            mFlingAnimationUtilsClosing.apply(animator, currentHeight, targetHeight, velocity,

packages/SystemUI/src/com/android/systemui/statusbar/NotificationShadeDepthController.kt

+4 −1
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ import com.android.systemui.statusbar.phone.BiometricUnlockController 
import com.android.systemui.statusbar.phone.BiometricUnlockController.MODE_WAKE_AND_UNLOCK

import com.android.systemui.statusbar.phone.DozeParameters

import com.android.systemui.statusbar.phone.ScrimController

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionChangeEvent

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionListener

import com.android.systemui.statusbar.policy.ConfigurationController

import com.android.systemui.statusbar.policy.KeyguardStateController
@@ -340,7 +341,9 @@ class NotificationShadeDepthController @Inject constructor( 
    /**

     * Update blurs when pulling down the shade

     */

    override fun onPanelExpansionChanged(rawFraction: Float, expanded: Boolean, tracking: Boolean) {

    override fun onPanelExpansionChanged(event: PanelExpansionChangeEvent) {

        val rawFraction = event.fraction

        val tracking = event.tracking

        val timestamp = SystemClock.elapsedRealtimeNanos()

        val expansion = MathUtils.saturate(

                (rawFraction - panelPullDownMinFraction) / (1f - panelPullDownMinFraction))

packages/SystemUI/src/com/android/systemui/statusbar/notification/NotificationWakeUpCoordinator.kt

+3 −2
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ import com.android.systemui.statusbar.notification.stack.StackStateAnimator 
import com.android.systemui.statusbar.phone.DozeParameters

import com.android.systemui.statusbar.phone.KeyguardBypassController

import com.android.systemui.statusbar.phone.ScreenOffAnimationController

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionChangeEvent

import com.android.systemui.statusbar.phone.panelstate.PanelExpansionListener

import com.android.systemui.statusbar.policy.HeadsUpManager

import com.android.systemui.statusbar.policy.OnHeadsUpChangedListener
@@ -292,8 +293,8 @@ class NotificationWakeUpCoordinator @Inject constructor( 
        this.state = newState

    }



    override fun onPanelExpansionChanged(fraction: Float, expanded: Boolean, tracking: Boolean) {

        val collapsedEnough = fraction <= 0.9f

    override fun onPanelExpansionChanged(event: PanelExpansionChangeEvent) {

        val collapsedEnough = event.fraction <= 0.9f

        if (collapsedEnough != this.collapsedEnoughToHide) {

            val couldShowPulsingHuns = canShowPulsingHuns

            this.collapsedEnoughToHide = collapsedEnough