Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09abb1f4 authored by Julia Reynolds's avatar Julia Reynolds
Browse files

Add missing test coverage 

In preparation for a minor refactor. Rather than writing
tests for the code guarded by ENABLE_LOCK_SCREEN_ALLOW_REMOTE_INPUT,
I've deleted it, since it's been disabled since at least 2017.

Test: NotificationLockscreenUserManagerTest
Bug: 286230167
Change-Id: Id31bd0f997022ac7b4ad527120e45e47736def12
parent 102064b4

packages/SystemUI/src/com/android/systemui/statusbar/NotificationLockscreenUserManager.java

+0 −2
Original line number Diff line number Diff line
@@ -24,8 +24,6 @@ public interface NotificationLockscreenUserManager { 
    String NOTIFICATION_UNLOCKED_BY_WORK_CHALLENGE_ACTION

            = "com.android.systemui.statusbar.work_challenge_unlocked_notification_action";



    boolean shouldAllowLockscreenRemoteInput();



    /**

     * @param userId user Id

     * @return true if we re on a secure lock screen

packages/SystemUI/src/com/android/systemui/statusbar/NotificationLockscreenUserManagerImpl.java

+2 −68
Original line number Diff line number Diff line
@@ -61,14 +61,14 @@ import com.android.systemui.statusbar.policy.KeyguardStateController; 
import com.android.systemui.util.ListenerSet;

import com.android.systemui.util.settings.SecureSettings;



import dagger.Lazy;



import java.io.PrintWriter;

import java.util.ArrayList;

import java.util.List;



import javax.inject.Inject;



import dagger.Lazy;



/**

 * Handles keeping track of the current user, profiles, and various things related to hiding

 * contents, redacting notifications, and the lockscreen.
@@ -79,8 +79,6 @@ public class NotificationLockscreenUserManagerImpl implements 
        NotificationLockscreenUserManager,

        StateListener {

    private static final String TAG = "LockscreenUserManager";

    private static final boolean ENABLE_LOCK_SCREEN_ALLOW_REMOTE_INPUT = false;



    private final DeviceProvisionedController mDeviceProvisionedController;

    private final KeyguardStateController mKeyguardStateController;

    private final SecureSettings mSecureSettings;
@@ -102,7 +100,6 @@ public class NotificationLockscreenUserManagerImpl implements 
    private final NotificationClickNotifier mClickNotifier;

    private final Lazy<OverviewProxyService> mOverviewProxyServiceLazy;

    private boolean mShowLockscreenNotifications;

    private boolean mAllowLockscreenRemoteInput;

    private LockPatternUtils mLockPatternUtils;

    protected KeyguardManager mKeyguardManager;

    private int mState = StatusBarState.SHADE;
@@ -285,14 +282,6 @@ public class NotificationLockscreenUserManagerImpl implements 
                Settings.Global.getUriFor(Settings.Global.ZEN_MODE), false,

                mSettingsObserver);



        if (ENABLE_LOCK_SCREEN_ALLOW_REMOTE_INPUT) {

            mContext.getContentResolver().registerContentObserver(

                    mSecureSettings.getUriFor(Settings.Secure.LOCK_SCREEN_ALLOW_REMOTE_INPUT),

                    false,

                    mSettingsObserver,

                    UserHandle.USER_ALL);

        }



        mBroadcastDispatcher.registerReceiver(mAllUsersReceiver,

                new IntentFilter(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED),

                null /* handler */, UserHandle.ALL);
@@ -323,10 +312,6 @@ public class NotificationLockscreenUserManagerImpl implements 
        return mShowLockscreenNotifications;

    }



    public boolean shouldAllowLockscreenRemoteInput() {

        return mAllowLockscreenRemoteInput;

    }



    public boolean isCurrentProfile(int userId) {

        synchronized (mLock) {

            return userId == UserHandle.USER_ALL || mCurrentProfiles.get(userId) != null;
@@ -337,10 +322,6 @@ public class NotificationLockscreenUserManagerImpl implements 
        mShowLockscreenNotifications = show;

    }



    private void setLockscreenAllowRemoteInput(boolean allowLockscreenRemoteInput) {

        mAllowLockscreenRemoteInput = allowLockscreenRemoteInput;

    }



    protected void updateLockscreenNotificationSetting() {

        final boolean show = mSecureSettings.getIntForUser(

                Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS,
@@ -352,19 +333,6 @@ public class NotificationLockscreenUserManagerImpl implements 
                & DevicePolicyManager.KEYGUARD_DISABLE_SECURE_NOTIFICATIONS) == 0;



        setShowLockscreenNotifications(show && allowedByDpm);



        if (ENABLE_LOCK_SCREEN_ALLOW_REMOTE_INPUT) {

            final boolean remoteInput = mSecureSettings.getIntForUser(

                    Settings.Secure.LOCK_SCREEN_ALLOW_REMOTE_INPUT,

                    0,

                    mCurrentUserId) != 0;

            final boolean remoteInputDpm =

                    (dpmFlags & DevicePolicyManager.KEYGUARD_DISABLE_REMOTE_INPUT) == 0;



            setLockscreenAllowRemoteInput(remoteInput && remoteInputDpm);

        } else {

            setLockscreenAllowRemoteInput(false);

        }

    }



    /**
@@ -452,7 +420,6 @@ public class NotificationLockscreenUserManagerImpl implements 
            mUsersAllowingNotifications.append(userHandle, allowed);

            return allowed;

        }



        return mUsersAllowingNotifications.get(userHandle);

    }
@@ -619,37 +586,6 @@ public class NotificationLockscreenUserManagerImpl implements 
        }

    }



//    public void updatePublicMode() {

//        //TODO: I think there may be a race condition where mKeyguardViewManager.isShowing() returns

//        // false when it should be true. Therefore, if we are not on the SHADE, don't even bother

//        // asking if the keyguard is showing. We still need to check it though because showing the

//        // camera on the keyguard has a state of SHADE but the keyguard is still showing.

//        final boolean showingKeyguard = mState != StatusBarState.SHADE

//              || mKeyguardStateController.isShowing();

//        final boolean devicePublic = showingKeyguard && isSecure(getCurrentUserId());

//

//

//        // Look for public mode users. Users are considered public in either case of:

//        //   - device keyguard is shown in secure mode;

//        //   - profile is locked with a work challenge.

//        SparseArray<UserInfo> currentProfiles = getCurrentProfiles();

//        for (int i = currentProfiles.size() - 1; i >= 0; i--) {

//            final int userId = currentProfiles.valueAt(i).id;

//            boolean isProfilePublic = devicePublic;

//            if (!devicePublic && userId != getCurrentUserId()) {

//                // We can't rely on KeyguardManager#isDeviceLocked() for unified profile challenge

//                // due to a race condition where this code could be called before

//                // TrustManagerService updates its internal records, resulting in an incorrect

//                // state being cached in mLockscreenPublicMode. (b/35951989)

//                if (mLockPatternUtils.isSeparateProfileChallengeEnabled(userId)

//                        && isSecure(userId)) {

//                    isProfilePublic = mKeyguardManager.isDeviceLocked(userId);

//                }

//            }

//            setLockscreenPublicMode(isProfilePublic, userId);

//        }

//    }



    @Override

    public void dump(PrintWriter pw, String[] args) {

        pw.println("NotificationLockscreenUserManager state:");
@@ -657,8 +593,6 @@ public class NotificationLockscreenUserManagerImpl implements 
        pw.println(mCurrentUserId);

        pw.print("  mShowLockscreenNotifications=");

        pw.println(mShowLockscreenNotifications);

        pw.print("  mAllowLockscreenRemoteInput=");

        pw.println(mAllowLockscreenRemoteInput);

        pw.print("  mCurrentProfiles=");

        synchronized (mLock) {

            for (int i = mCurrentProfiles.size() - 1; i >= 0; i--) {

packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java

+0 −3
Original line number Diff line number Diff line
@@ -482,9 +482,6 @@ public class NotificationRemoteInputManager implements Dumpable { 


    private boolean showBouncerForRemoteInput(View view, PendingIntent pendingIntent,

            ExpandableNotificationRow row) {

        if (mLockscreenUserManager.shouldAllowLockscreenRemoteInput()) {

            return false;

        }



        final int userId = pendingIntent.getCreatorUserHandle().getIdentifier();

packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationLockscreenUserManagerTest.java

+275 −3
Original line number Diff line number Diff line
@@ -16,9 +16,18 @@ 


package com.android.systemui.statusbar;



import static android.app.admin.DevicePolicyManager.ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED;

import static android.app.admin.DevicePolicyManager.KEYGUARD_DISABLE_SECURE_NOTIFICATIONS;

import static android.app.admin.DevicePolicyManager.KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS;

import static android.os.UserHandle.USER_ALL;

import static android.provider.Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS;



import static junit.framework.Assert.assertFalse;

import static junit.framework.Assert.assertTrue;



import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.Mockito.atMost;

import static org.mockito.Mockito.clearInvocations;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.never;
@@ -32,6 +41,7 @@ import android.app.Notification; 
import android.app.admin.DevicePolicyManager;

import android.content.BroadcastReceiver;

import android.content.Context;

import android.content.Intent;

import android.content.pm.UserInfo;

import android.database.ContentObserver;

import android.os.Handler;
@@ -64,6 +74,7 @@ import com.android.systemui.util.settings.FakeSettings; 
import com.google.android.collect.Lists;



import org.junit.Before;

import org.junit.Ignore;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.mockito.Mock;
@@ -124,8 +135,11 @@ public class NotificationLockscreenUserManagerTest extends SysuiTestCase { 
        mWorkUser = new UserInfo(currentUserId + 2, "" /* name */, null /* iconPath */, 0,

                UserManager.USER_TYPE_PROFILE_MANAGED);



        when(mKeyguardManager.getPrivateNotificationsAllowed()).thenReturn(true);

        when(mUserManager.getProfiles(currentUserId)).thenReturn(Lists.newArrayList(

                mCurrentUser, mSecondaryUser, mWorkUser));

                mCurrentUser, mWorkUser));

        when(mUserManager.getProfiles(mSecondaryUser.id)).thenReturn(Lists.newArrayList(

                mSecondaryUser));

        mDependency.injectTestDependency(Dependency.MAIN_HANDLER,

                Handler.createAsync(Looper.myLooper()));
@@ -150,14 +164,14 @@ public class NotificationLockscreenUserManagerTest extends SysuiTestCase { 


    @Test

    public void testLockScreenShowNotificationsFalse() {

        mSettings.putInt(Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS, 0);

        mSettings.putInt(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);

        assertFalse(mLockscreenUserManager.shouldShowLockscreenNotifications());

    }



    @Test

    public void testLockScreenShowNotificationsTrue() {

        mSettings.putInt(Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS, 1);

        mSettings.putInt(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);

        assertTrue(mLockscreenUserManager.shouldShowLockscreenNotifications());

    }
@@ -224,6 +238,7 @@ public class NotificationLockscreenUserManagerTest extends SysuiTestCase { 


        // THEN work profile notification is redacted

        assertTrue(mLockscreenUserManager.needsRedaction(mWorkProfileNotif));

        assertFalse(mLockscreenUserManager.allowsManagedPrivateNotificationsInPublic());

    }



    @Test
@@ -235,6 +250,7 @@ public class NotificationLockscreenUserManagerTest extends SysuiTestCase { 


        // THEN work profile notification isn't redacted

        assertFalse(mLockscreenUserManager.needsRedaction(mWorkProfileNotif));

        assertTrue(mLockscreenUserManager.allowsManagedPrivateNotificationsInPublic());

    }



    @Test
@@ -336,6 +352,262 @@ public class NotificationLockscreenUserManagerTest extends SysuiTestCase { 
        verify(listener, never()).onNotificationStateChanged();

    }



    @Test

    public void testDevicePolicyDoesNotAllowNotifications() {

        // User allows them

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides notifs on lockscreen

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(KEYGUARD_DISABLE_SECURE_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));

    }



    @Ignore("b/286230167")

    @Test

    public void testDevicePolicyDoesNotAllowNotifications_userAll() {

        // User allows them

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides notifications

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(KEYGUARD_DISABLE_SECURE_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(USER_ALL));

    }



    @Test

    @Ignore("b/286230167")

    public void testDevicePolicyDoesNotAllowNotifications_secondary() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mSecondaryUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides notifications

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mSecondaryUser.id))

                .thenReturn(KEYGUARD_DISABLE_SECURE_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mSecondaryUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mSecondaryUser.id));



        // TODO (b/286230167): enable assertion

        verify(mDevicePolicyManager, atMost(1)).getKeyguardDisabledFeatures(any(), anyInt());

    }



    @Test

    public void testDevicePolicy_noPrivateNotifications() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides sensitive content

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertTrue(mLockscreenUserManager.needsRedaction(mCurrentUserNotif));



        // TODO (b/286230167): enable assertion. It's currently called 4 times.

        //verify(mDevicePolicyManager, atMost(1)).getKeyguardDisabledFeatures(any(), anyInt());

    }



    @Test

    public void testDevicePolicy_noPrivateNotifications_userAll() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides sensitive content

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertTrue(mLockscreenUserManager.needsRedaction(new NotificationEntryBuilder()

                .setNotification(new Notification())

                .setUser(UserHandle.ALL)

                .build()));

    }



    @Test

    public void testDevicePolicyPrivateNotifications_secondary() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mSecondaryUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        // DevicePolicy hides sensitive content

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mSecondaryUser.id))

                .thenReturn(KEYGUARD_DISABLE_UNREDACTED_NOTIFICATIONS);



        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mSecondaryUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertTrue(mLockscreenUserManager.needsRedaction(mSecondaryUserNotif));



        // TODO (b/286230167): enable assertion. It's currently called 5 times.

        //verify(mDevicePolicyManager, atMost(1)).getKeyguardDisabledFeatures(any(), anyInt());

    }



    @Test

    public void testHideNotifications_primary() {

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));

    }



    @Test

    public void testHideNotifications_secondary() {

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0, mSecondaryUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mSecondaryUser.id));

    }



    @Ignore("b/286230167")

    @Test

    public void testHideNotifications_workProfile() {

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0, mWorkUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mWorkUser.id));

    }



    @Test

    public void testHideNotifications_secondary_userSwitch() {

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0, mSecondaryUser.id);



        TestNotificationLockscreenUserManager lockscreenUserManager

                = new TestNotificationLockscreenUserManager(mContext);

        lockscreenUserManager.setUpWithPresenter(mPresenter);



        lockscreenUserManager.mUserChangedCallback.onUserChanging(mSecondaryUser.id, mContext);



        assertFalse(lockscreenUserManager.userAllowsNotificationsInPublic(mSecondaryUser.id));

    }



    @Test

    public void testShowNotifications_secondary_userSwitch() {

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mSecondaryUser.id);



        TestNotificationLockscreenUserManager lockscreenUserManager

                = new TestNotificationLockscreenUserManager(mContext);

        lockscreenUserManager.setUpWithPresenter(mPresenter);



        lockscreenUserManager.mUserChangedCallback.onUserChanging(mSecondaryUser.id, mContext);



        assertTrue(lockscreenUserManager.userAllowsNotificationsInPublic(mSecondaryUser.id));

    }



    @Ignore("b/286230167")

    @Test

    public void testShouldShowLockscreenNotifications_keyguardManagerNoPrivateNotifications() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);

        // DevicePolicy allows notifications

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(0);

        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        // KeyguardManager does not

        when(mKeyguardManager.getPrivateNotificationsAllowed()).thenReturn(false);



        assertFalse(mLockscreenUserManager.shouldShowLockscreenNotifications());

    }



    @Test

    public void testUserAllowsNotificationsInPublic_keyguardManagerNoPrivateNotifications() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);

        // DevicePolicy allows notifications

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(0);

        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        // KeyguardManager does not

        when(mKeyguardManager.getPrivateNotificationsAllowed()).thenReturn(false);



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));

    }



    @Test

    public void testUserAllowsNotificationsInPublic_settingsChange() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertTrue(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));



        // User disables

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 0, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));

    }



    @Ignore("b/286230167")

    @Test

    public void testUserAllowsNotificationsInPublic_devicePolicyChange() {

        // User allows notifications

        mSettings.putIntForUser(LOCK_SCREEN_SHOW_NOTIFICATIONS, 1, mCurrentUser.id);

        mLockscreenUserManager.getLockscreenSettingsObserverForTest().onChange(false);



        assertTrue(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));



        // DevicePolicy disables notifications

        when(mDevicePolicyManager.getKeyguardDisabledFeatures(null, mCurrentUser.id))

                .thenReturn(KEYGUARD_DISABLE_SECURE_NOTIFICATIONS);

        BroadcastReceiver.PendingResult pr = mock(BroadcastReceiver.PendingResult.class);

        when(pr.getSendingUserId()).thenReturn(mCurrentUser.id);

        mLockscreenUserManager.mAllUsersReceiver.setPendingResult(pr);

        mLockscreenUserManager.mAllUsersReceiver.onReceive(mContext,

                new Intent(ACTION_DEVICE_POLICY_MANAGER_STATE_CHANGED));



        assertFalse(mLockscreenUserManager.userAllowsNotificationsInPublic(mCurrentUser.id));

    }



    private class TestNotificationLockscreenUserManager

            extends NotificationLockscreenUserManagerImpl {

        public TestNotificationLockscreenUserManager(Context context) {