Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 098a5f2a authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[SB] Remove outdated TODOs in chip model classes. 

- Colors not changing is only a problem when ChipsModernization is off
- The chip text length is limited in the UI code

Bug: 364653005
Flag: EXEMPT comment-only change
Test: compiles
Change-Id: Iaf8c8de326aabbcf999b015186ddfaa0eb495b51
parent 86c44cf9

packages/SystemUI/src/com/android/systemui/statusbar/chips/ui/model/ColorsModel.kt

+3 −2
Original line number Diff line number Diff line
@@ -46,8 +46,9 @@ sealed interface ColorsModel { 
    }



    /** The chip should match the system theme main color. */

    // TODO(b/347717946): The chip's color isn't getting updated when the user switches theme, it

    // only gets updated when a different configuration change happens, like a rotation.

    // Note: When StatusBarChipsModernization is disabled, the chip's color doesn't get

    // updated when the user switches theme. It only gets updated when a different

    // configuration change happens, like a rotation.

    data object SystemThemed : ColorsModel {

        override fun background(context: Context): ColorStateList =

            ColorStateList.valueOf(

packages/SystemUI/src/com/android/systemui/statusbar/chips/ui/model/OngoingActivityChipModel.kt

+0 −1
Original line number Diff line number Diff line
@@ -235,7 +235,6 @@ sealed class OngoingActivityChipModel { 
            override val isImportantForPrivacy: Boolean = false,

            override val icon: ChipIcon,

            override val colors: ColorsModel,

            // TODO(b/361346412): Enforce a max length requirement?

            val text: String,

            override val onClickListenerLegacy: View.OnClickListener? = null,

            override val clickBehavior: ClickBehavior,