Merge \"Reduce shell power over user management.\" into nyc-dev (0979d718) · Commits · e / os / android_frameworks_base

core/res/AndroidManifest.xml

+8 −0

Original line number	Diff line number	Diff line
		@@ -1622,6 +1622,14 @@
		<permission android:name="android.permission.MANAGE_USERS"
		android:protectionLevel="signature\|privileged" />

		<!-- @hide Allows an application to create, remove users and get the list of
		users on the device. Applications holding this permission can only create restricted,
		guest, managed, and ephemeral users. For creating other kind of users,
		{@link android.Manifest.permission#MANAGE_USERS} is needed.
		This permission is not available to third party applications. -->
		<permission android:name="android.permission.CREATE_USERS"
		android:protectionLevel="signature" />

		<!-- @hide Allows an application to set the profile owners and the device owner.
		This permission is not available to third party applications.-->
		<permission android:name="android.permission.MANAGE_PROFILE_AND_DEVICE_OWNERS"

packages/Shell/AndroidManifest.xml

+1 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,7 @@
		<uses-permission android:name="android.permission.WRITE_MEDIA_STORAGE" />
		<uses-permission android:name="android.permission.INTERACT_ACROSS_USERS" />
		<uses-permission android:name="android.permission.INTERACT_ACROSS_USERS_FULL" />
		<uses-permission android:name="android.permission.MANAGE_USERS" />
		<uses-permission android:name="android.permission.CREATE_USERS" />
		<uses-permission android:name="android.permission.MANAGE_DEVICE_ADMINS" />
		<uses-permission android:name="android.permission.BLUETOOTH_STACK" />
		<uses-permission android:name="android.permission.GET_ACCOUNTS" />

services/core/java/com/android/server/pm/UserManagerService.java

+62 −4

Original line number	Diff line number	Diff line
		@@ -167,6 +167,12 @@ public class UserManagerService extends IUserManager.Stub {
		private static final String RESTRICTIONS_FILE_PREFIX = "res_";
		private static final String XML_SUFFIX = ".xml";

		private static final int ALLOWED_FLAGS_FOR_CREATE_USERS_PERMISSION =
		UserInfo.FLAG_MANAGED_PROFILE
		\| UserInfo.FLAG_EPHEMERAL
		\| UserInfo.FLAG_RESTRICTED
		\| UserInfo.FLAG_GUEST;

		private static final int MIN_USER_ID = 10;
		// We need to keep process uid within Integer.MAX_VALUE.
		private static final int MAX_USER_ID = Integer.MAX_VALUE / UserHandle.PER_USER_RANGE;
		@@ -465,7 +471,7 @@ public class UserManagerService extends IUserManager.Stub {

		@Override
		public @NonNull List<UserInfo> getUsers(boolean excludeDying) {
		checkManageUsersPermission("query users");
		checkManageOrCreateUsersPermission("query users");
		synchronized (mUsersLock) {
		ArrayList<UserInfo> users = new ArrayList<UserInfo>(mUsers.size());
		final int userSize = mUsers.size();
		@@ -1406,6 +1412,41 @@ public class UserManagerService extends IUserManager.Stub {
		}
		}

		/**
		* Enforces that only the system UID or root's UID or apps that have the
		* {@link android.Manifest.permission#MANAGE_USERS MANAGE_USERS} or
		* {@link android.Manifest.permission#CREATE_USERS CREATE_USERS}
		* can make certain calls to the UserManager.
		*
		* @param message used as message if SecurityException is thrown
		* @throws SecurityException if the caller is not system or root
		* @see #hasManageOrCreateUsersPermission()
		*/
		private static final void checkManageOrCreateUsersPermission(String message) {
		if (!hasManageOrCreateUsersPermission()) {
		throw new SecurityException(
		"You either need MANAGE_USERS or CREATE_USERS permission to: " + message);
		}
		}

		/**
		* Similar to {@link #checkManageOrCreateUsersPermission(String)} but when the caller is tries
		* to create user/profiles other than what is allowed for
		* {@link android.Manifest.permission#CREATE_USERS CREATE_USERS} permission, then it will only
		* allow callers with {@link android.Manifest.permission#MANAGE_USERS MANAGE_USERS} permission.
		*/
		private static final void checkManageOrCreateUsersPermission(int creationFlags) {
		if ((creationFlags & ~ALLOWED_FLAGS_FOR_CREATE_USERS_PERMISSION) == 0) {
		if (!hasManageOrCreateUsersPermission()) {
		throw new SecurityException("You either need MANAGE_USERS or CREATE_USERS "
		+ "permission to create an user with flags: " + creationFlags);
		}
		} else if (!hasManageUsersPermission()) {
		throw new SecurityException("You need MANAGE_USERS permission to create an user "
		+ " with flags: " + creationFlags);
		}
		}

		/**
		* @return whether the calling UID is system UID or root's UID or the calling app has the
		* {@link android.Manifest.permission#MANAGE_USERS MANAGE_USERS}.
		@@ -1419,6 +1460,23 @@ public class UserManagerService extends IUserManager.Stub {
		callingUid, -1, true) == PackageManager.PERMISSION_GRANTED;
		}

		/**
		* @return whether the calling UID is system UID or root's UID or the calling app has the
		* {@link android.Manifest.permission#MANAGE_USERS MANAGE_USERS} or
		* {@link android.Manifest.permission#CREATE_USERS CREATE_USERS}.
		*/
		private static final boolean hasManageOrCreateUsersPermission() {
		final int callingUid = Binder.getCallingUid();
		return UserHandle.isSameApp(callingUid, Process.SYSTEM_UID)
		\|\| callingUid == Process.ROOT_UID
		\|\| ActivityManager.checkComponentPermission(
		android.Manifest.permission.MANAGE_USERS,
		callingUid, -1, true) == PackageManager.PERMISSION_GRANTED
		\|\| ActivityManager.checkComponentPermission(
		android.Manifest.permission.CREATE_USERS,
		callingUid, -1, true) == PackageManager.PERMISSION_GRANTED;
		}

		/**
		* Enforces that only the system UID or root's UID (on any user) can make certain calls to the
		* UserManager.
		@@ -2005,13 +2063,13 @@ public class UserManagerService extends IUserManager.Stub {

		@Override
		public UserInfo createProfileForUser(String name, int flags, int userId) {
		checkManageUsersPermission("Only the system can create users");
		checkManageOrCreateUsersPermission(flags);
		return createUserInternal(name, flags, userId);
		}

		@Override
		public UserInfo createUser(String name, int flags) {
		checkManageUsersPermission("Only the system can create users");
		checkManageOrCreateUsersPermission(flags);
		return createUserInternal(name, flags, UserHandle.USER_NULL);
		}

		@@ -2255,7 +2313,7 @@ public class UserManagerService extends IUserManager.Stub {
		*/
		@Override
		public boolean removeUser(int userHandle) {
		checkManageUsersPermission("Only the system can remove users");
		checkManageOrCreateUsersPermission("Only the system can remove users");
		if (getUserRestrictions(UserHandle.getCallingUserId()).getBoolean(
		UserManager.DISALLOW_REMOVE_USER, false)) {
		Log.w(LOG_TAG, "Cannot remove user. DISALLOW_REMOVE_USER is enabled.");