Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07d0e4df authored by Ashwini Oruganti's avatar Ashwini Oruganti
Browse files

NotificationManagerServiceTest: Mark unaudited PendingIntents with FLAG_MUTABLE_UNAUDITED 

These PIs need an explicit mutability flag. This temporay flag is being
used to mark these points in code and should be replaced ASAP.
See go/immutable-pendingintents for more context.

Bug: 160794467
Test: TH
Exempt-From-Owner-Approval: noop change
Change-Id: Ice453974aafd943722c0ad44e017fdf1ca3237a9
parent f2b1d840

services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java

+12 −3
Original line number Diff line number Diff line
@@ -790,7 +790,10 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
                .setName("bubblebot")

                .build();

        RemoteInput remoteInput = new RemoteInput.Builder("reply_key").setLabel("reply").build();

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(), 0);

        // TODO(b/174965245) Please replace FLAG_MUTABLE_UNAUDITED below

        // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE.

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(),

                PendingIntent.FLAG_MUTABLE_UNAUDITED);

        Icon icon = Icon.createWithResource(mContext, android.R.drawable.sym_def_app_icon);

        Notification.Action replyAction = new Notification.Action.Builder(icon, "Reply",

                inputIntent).addRemoteInput(remoteInput)
@@ -7366,7 +7369,10 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
        NotificationRecord r = generateNotificationRecord(mTestNotificationChannel);

        ArrayList<Notification.Action> extraAction = new ArrayList<>();

        RemoteInput remoteInput = new RemoteInput.Builder("reply_key").setLabel("reply").build();

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(), 0);

        // TODO(b/174965245) Please replace FLAG_MUTABLE_UNAUDITED below

        // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE.

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(),

                PendingIntent.FLAG_MUTABLE_UNAUDITED);

        Icon icon = Icon.createWithResource(mContext, android.R.drawable.sym_def_app_icon);

        Notification.Action replyAction = new Notification.Action.Builder(icon, "Reply",

                inputIntent).addRemoteInput(remoteInput)
@@ -7396,7 +7402,10 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
        NotificationRecord r = generateNotificationRecord(mTestNotificationChannel);

        ArrayList<Notification.Action> extraAction = new ArrayList<>();

        RemoteInput remoteInput = new RemoteInput.Builder("reply_key").setLabel("reply").build();

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(), 0);

        // TODO(b/174965245) Please replace FLAG_MUTABLE_UNAUDITED below

        // with either FLAG_IMMUTABLE (recommended) or FLAG_MUTABLE.

        PendingIntent inputIntent = PendingIntent.getActivity(mContext, 0, new Intent(),

                PendingIntent.FLAG_MUTABLE_UNAUDITED);

        Icon icon = Icon.createWithResource(mContext, android.R.drawable.sym_def_app_icon);

        Notification.Action replyAction = new Notification.Action.Builder(icon, "Reply",

                inputIntent).addRemoteInput(remoteInput)