Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07229fd5 authored by Daniel Hsieh's avatar Daniel Hsieh
Browse files

Disables tracking focus on move a11y actions. 

After a user perform a11y action, namely moving up/down/left/right, we
have to disable tracking focus functionality.

We refactor #onDrag to a more general term #onMove to cover any move
action which has to disable tracking focus functionality.

Bug: 218935435
Test: atest WindowMagnificationTest
      atest WindowMagnificationControllerTest
      atest WindowMagnificationManagerTest
Change-Id: I578b301645a08c71e874fe2f4fcf2557202abefd
parent 74db862d

core/java/android/view/accessibility/IWindowMagnificationConnectionCallback.aidl

+2 −4
Original line number Diff line number Diff line
@@ -68,12 +68,10 @@ import android.graphics.Rect; 
    void onAccessibilityActionPerformed(int displayId);



    /**

     * Called when the user is performing dragging gesture. It is started after the offset

     * between the down location and the move event location exceed

     * {@link ViewConfiguration#getScaledTouchSlop()}.

     * Called when the user is performing move action.

     *

     * @param displayId The logical display id.

     */

    void onDrag(int displayId);

    void onMove(int displayId);



}

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnification.java

+2 −2
Original line number Diff line number Diff line
@@ -221,9 +221,9 @@ public class WindowMagnification extends CoreStartable implements WindowMagnifie 
    }



    @Override

    public void onDrag(int displayId) {

    public void onMove(int displayId) {

        if (mWindowMagnificationConnectionImpl != null) {

            mWindowMagnificationConnectionImpl.onDrag(displayId);

            mWindowMagnificationConnectionImpl.onMove(displayId);

        }

    }

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationConnectionImpl.java

+2 −2
Original line number Diff line number Diff line
@@ -150,10 +150,10 @@ class WindowMagnificationConnectionImpl extends IWindowMagnificationConnection.S 
        }

    }



    void onDrag(int displayId) {

    void onMove(int displayId) {

        if (mConnectionCallback != null) {

            try {

                mConnectionCallback.onDrag(displayId);

                mConnectionCallback.onMove(displayId);

            } catch (RemoteException e) {

                Log.e(TAG, "Failed to inform taking control by a user", e);

            }

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java

+2 −2
Original line number Diff line number Diff line
@@ -852,6 +852,7 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold 
    @Override

    public void move(int xOffset, int yOffset) {

        moveWindowMagnifier(xOffset, yOffset);

        mWindowMagnifierCallback.onMove(mDisplayId);

    }



    /**
@@ -1045,8 +1046,7 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold 


    @Override

    public boolean onDrag(float offsetX, float offsetY) {

        moveWindowMagnifier(offsetX, offsetY);

        mWindowMagnifierCallback.onDrag(mDisplayId);

        move((int) offsetX, (int) offsetY);

        return true;

    }

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnifierCallback.java

+2 −5
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ 
package com.android.systemui.accessibility;



import android.graphics.Rect;

import android.view.ViewConfiguration;



/**

 * A callback to inform {@link com.android.server.accessibility.AccessibilityManagerService} about
@@ -56,11 +55,9 @@ interface WindowMagnifierCallback { 
    void onAccessibilityActionPerformed(int displayId);



    /**

     * Called when the user is performing dragging gesture. It is started after the offset

     * between the down location and the move event location exceed

     * {@link ViewConfiguration#getScaledTouchSlop()}.

     * Called when the user is performing a move action.

     *

     * @param displayId The logical display id.

     */

    void onDrag(int displayId);

    void onMove(int displayId);

}