Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06e45501 authored by Steven Moreland's avatar Steven Moreland
Browse files

Parcel: warnings for 'REPLY' statuses 

Comment a warning for this hack to add data into statuses. I've also
heard from jsharkey@ in the past a need for a generic solution here.
At a minimum, this prevents new bugs/bad interactions with native
code.

Bug: 235006086
Test: N/A
Change-Id: I3bcb2b8638803cde0f6ef257b65bb9456843abf7
parent 92ce7440

core/java/android/os/Parcel.java

+8 −0
Original line number Diff line number Diff line
@@ -347,7 +347,15 @@ public final class Parcel { 
    private static final int EX_SERVICE_SPECIFIC = -8;

    private static final int EX_PARCELABLE = -9;

    /** @hide */

    // WARNING: DO NOT add more 'reply' headers. These also need to add work to native

    // code and this encodes extra information in object statuses. If we need to expand

    // this design, we should add a generic way to attach parcelables/structured parcelables

    // to transactions which can work across languages.

    public static final int EX_HAS_NOTED_APPOPS_REPLY_HEADER = -127; // special; see below

    // WARNING: DO NOT add more 'reply' headers. These also need to add work to native

    // code and this encodes extra information in object statuses. If we need to expand

    // this design, we should add a generic way to attach parcelables/structured parcelables

    // to transactions which can work across languages.

    private static final int EX_HAS_STRICTMODE_REPLY_HEADER = -128;  // special; see below

    // EX_TRANSACTION_FAILED is used exclusively in native code.

    // see libbinder's binder/Status.h