Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0658e8fe authored by Leon Scroggins's avatar Leon Scroggins
Browse files

If the cursor moves from a focused textfield to another, remove the WebTextView. 

We already remove the blinking caret, implying that if the user
types with the cursor on another textfield, the keys will go there.
This way, the WebView will see the key, and rebuild the WebTextView,
so we no longer use the data from the first textfield.  This fixes
a bug where moving from a focused textfield and pressing delete
with the cursor on another was deleting a character from the
first (initially focused) textfield.  Also, in WebView::onKeyDown,
only check if the native cursor is a textfield before deciding
whether to send a CLICK, since plugins will be handled differently
(this is part of a different change), and now the cursor may match
the focus, but we still want the click (to make the focusController
active - i.e. make the cursor blink).
parent 243ea06d

core/java/android/webkit/WebView.java

+22 −13
Original line number Diff line number Diff line
@@ -3285,18 +3285,16 @@ public class WebView extends AbsoluteLayout 
        if (nativeCursorIsPlugin()) {

            nativeUpdatePluginReceivesEvents();

            invalidate();

        } else if (nativeCursorWantsKeyEvents() && !nativeCursorMatchesFocus()) {

        } else if (nativeCursorIsTextInput()) {

            // This message will put the node in focus, for the DOM's notion

            // of focus

            // of focus, and make the focuscontroller active

            mWebViewCore.sendMessage(EventHub.CLICK);

            if (nativeCursorIsTextInput()) {

            // This will bring up the WebTextView and put it in focus, for

            // our view system's notion of focus

            rebuildWebTextView();

            // Now we need to pass the event to it

            return mWebTextView.onKeyDown(keyCode, event);

        }

        }



        // TODO: should we pass all the keys to DOM or check the meta tag

        if (nativeCursorWantsKeyEvents() || true) {
@@ -5180,12 +5178,23 @@ public class WebView extends AbsoluteLayout 
                new WebViewCore.CursorData(frame, node, x, y));

    }



    // called by JNI

    private void sendMoveMouseIfLatest(boolean setFocusControllerInactive) {

        if (setFocusControllerInactive) {

    /*

     * Send a mouse move event to the webcore thread.

     *

     * @param removeFocus Pass true if the "mouse" cursor is now over a node

     *                    which wants key events, but it is not the focus. This

     *                    will make the visual appear as though nothing is in

     *                    focus.  Remove the WebTextView, if present, and stop

     *                    drawing the blinking caret.

     * called by JNI

     */

    private void sendMoveMouseIfLatest(boolean removeFocus) {

        if (removeFocus) {

            clearTextEntry();

            setFocusControllerInactive();

        }

        mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE_IF_LATEST, cursorData());

        mWebViewCore.sendMessage(EventHub.SET_MOVE_MOUSE_IF_LATEST,

                cursorData());

    }



    // called by JNI