Fix some stale dataclass detector false positives (05ef53ed) · Commits · e / os / android_frameworks_base

tests/Codegen/runTest.sh

+1 −0

Original line number	Diff line number	Diff line
		@@ -16,6 +16,7 @@ else
		header_and_eval codegen $ANDROID_BUILD_TOP/frameworks/base/tests/Codegen/src/com/android/codegentest/ParcelAllTheThingsDataClass.java && \
		header_and_eval codegen $ANDROID_BUILD_TOP/frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassBase.java && \
		header_and_eval codegen $ANDROID_BUILD_TOP/frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassChild.java && \
		header_and_eval codegen $ANDROID_BUILD_TOP/frameworks/base/tests/Codegen/src/com/android/codegentest/StaleDataclassDetectorFalsePositivesTest.java && \
		cd $ANDROID_BUILD_TOP &&
		header_and_eval mmma -j16 frameworks/base/tests/Codegen && \
		header_and_eval adb install -r -t "$(find $ANDROID_TARGET_OUT_TESTCASES -name 'CodegenTests.apk')" && \

tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassBase.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -32,7 +32,7 @@ public class HierrarchicalDataClassBase implements Parcelable {



		// Code below generated by codegen v1.0.5.
		// Code below generated by codegen v1.0.7.
		//
		// DO NOT MODIFY!
		// CHECKSTYLE:OFF Generated code
		@@ -94,8 +94,8 @@ public class HierrarchicalDataClassBase implements Parcelable {
		};

		@DataClass.Generated(
		time = 1570231100269L,
		codegenVersion = "1.0.5",
		time = 1570576455287L,
		codegenVersion = "1.0.7",
		sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassBase.java",
		inputSignatures = "private int mBaseData\nclass HierrarchicalDataClassBase extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genConstructor=false, genSetters=true)")
		@Deprecated

tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassChild.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -46,7 +46,7 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {



		// Code below generated by codegen v1.0.5.
		// Code below generated by codegen v1.0.7.
		//
		// DO NOT MODIFY!
		// CHECKSTYLE:OFF Generated code
		@@ -116,8 +116,8 @@ public class HierrarchicalDataClassChild extends HierrarchicalDataClassBase {
		};

		@DataClass.Generated(
		time = 1570231101208L,
		codegenVersion = "1.0.5",
		time = 1570576456245L,
		codegenVersion = "1.0.7",
		sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/HierrarchicalDataClassChild.java",
		inputSignatures = "private @android.annotation.NonNull java.lang.String mChildData\nclass HierrarchicalDataClassChild extends com.android.codegentest.HierrarchicalDataClassBase implements []\n@com.android.internal.util.DataClass(genParcelable=true, genConstructor=false, genSetters=true)")
		@Deprecated

tests/Codegen/src/com/android/codegentest/ParcelAllTheThingsDataClass.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -48,7 +48,7 @@ public class ParcelAllTheThingsDataClass implements Parcelable {



		// Code below generated by codegen v1.0.5.
		// Code below generated by codegen v1.0.7.
		//
		// DO NOT MODIFY!
		// CHECKSTYLE:OFF Generated code
		@@ -374,8 +374,8 @@ public class ParcelAllTheThingsDataClass implements Parcelable {
		}

		@DataClass.Generated(
		time = 1570231099316L,
		codegenVersion = "1.0.5",
		time = 1570576454326L,
		codegenVersion = "1.0.7",
		sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/ParcelAllTheThingsDataClass.java",
		inputSignatures = " @android.annotation.NonNull java.lang.String[] mStringArray\n @android.annotation.NonNull int[] mIntArray\n @android.annotation.NonNull java.util.List<java.lang.String> mStringList\n @android.annotation.NonNull java.util.Map<java.lang.String,com.android.codegentest.SampleWithCustomBuilder> mMap\n @android.annotation.NonNull java.util.Map<java.lang.String,java.lang.String> mStringMap\n @android.annotation.NonNull android.util.SparseArray<com.android.codegentest.SampleWithCustomBuilder> mSparseArray\n @android.annotation.NonNull android.util.SparseIntArray mSparseIntArray\nclass ParcelAllTheThingsDataClass extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genBuilder=true, genAidl=false, genToString=true)")
		@Deprecated

tests/Codegen/src/com/android/codegentest/SampleDataClass.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -342,7 +342,7 @@ public final class SampleDataClass implements Parcelable {



		// Code below generated by codegen v1.0.5.
		// Code below generated by codegen v1.0.7.
		//
		// DO NOT MODIFY!
		// CHECKSTYLE:OFF Generated code
		@@ -1868,8 +1868,8 @@ public final class SampleDataClass implements Parcelable {
		}

		@DataClass.Generated(
		time = 1570231097226L,
		codegenVersion = "1.0.5",
		time = 1570576452225L,
		codegenVersion = "1.0.7",
		sourceFile = "frameworks/base/tests/Codegen/src/com/android/codegentest/SampleDataClass.java",
		inputSignatures = "public static final java.lang.String STATE_NAME_UNDEFINED\npublic static final java.lang.String STATE_NAME_ON\npublic static final java.lang.String STATE_NAME_OFF\npublic static final int STATE_UNDEFINED\npublic static final int STATE_ON\npublic static final int STATE_OFF\npublic static final @com.android.codegentest.SampleDataClass.RequestFlags int FLAG_MANUAL_REQUEST\npublic static final @com.android.codegentest.SampleDataClass.RequestFlags int FLAG_COMPATIBILITY_MODE_REQUEST\npublic static final @com.android.codegentest.SampleDataClass.RequestFlags int FLAG_AUGMENTED_REQUEST\nprivate int mNum\nprivate int mNum2\nprivate int mNum4\nprivate @android.annotation.Nullable java.lang.String mName\nprivate @android.annotation.NonNull java.lang.String mName2\nprivate @android.annotation.NonNull java.lang.String mName4\nprivate @android.annotation.Nullable android.view.accessibility.AccessibilityNodeInfo mOtherParcelable\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.codegentest.MyDateParcelling.class) @android.annotation.NonNull java.util.Date mDate\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForPattern.class) @android.annotation.NonNull java.util.regex.Pattern mPattern\nprivate @android.annotation.NonNull java.util.List<android.net.LinkAddress> mLinkAddresses2\nprivate @com.android.internal.util.DataClass.PluralOf(\"linkAddress\") @android.annotation.NonNull java.util.ArrayList<android.net.LinkAddress> mLinkAddresses\nprivate @android.annotation.Nullable android.net.LinkAddress[] mLinkAddresses4\nprivate @com.android.codegentest.SampleDataClass.StateName @android.annotation.NonNull java.lang.String mStateName\nprivate @com.android.codegentest.SampleDataClass.RequestFlags int mFlags\nprivate @com.android.codegentest.SampleDataClass.State int mState\npublic @android.annotation.NonNull java.lang.CharSequence charSeq\nprivate final @android.annotation.Nullable android.net.LinkAddress[] mLinkAddresses5\nprivate transient android.net.LinkAddress[] mLinkAddresses6\ntransient int[] mTmpStorage\nprivate @android.annotation.StringRes int mStringRes\nprivate @android.annotation.IntRange(from=0L, to=6L) int mDayOfWeek\nprivate @android.annotation.Size(2L) @android.annotation.NonNull @com.android.internal.util.DataClass.Each @android.annotation.FloatRange(from=0.0) float[] mCoords\nprivate static java.lang.String defaultName4()\nprivate int[] lazyInitTmpStorage()\npublic android.net.LinkAddress[] getLinkAddresses4()\nprivate boolean patternEquals(java.util.regex.Pattern)\nprivate int patternHashCode()\nprivate void onConstructed()\npublic void dump(java.io.PrintWriter)\nclass SampleDataClass extends java.lang.Object implements [android.os.Parcelable]\n@com.android.internal.util.DataClass(genBuilder=true, genConstructor=true, genEqualsHashCode=true, genToString=true, genForEachField=true, genSetters=true)")
		@Deprecated