Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0573c191 authored by Julia Tuttle's avatar Julia Tuttle
Browse files

NotificationTest: revert overeager BigPictureStyle changes 

When I fixed b/315128763 with ag/25693490, I accidentally updated two
unit test cases that weren't actually impacted by my fix.

Somehow, NotificationTest wasn't running *anywhere*, so we only noticed
this now.

Leave the two correctly updated unit test cases, but revert the two that
were updated in error.

Bug: 329402256
Test: atest NotificationTest
Flag: NA
Change-Id: I488c3753b4849a9ed19e1ee052bc1f2ae79485cf
parent e32f8861

core/tests/coretests/src/android/app/NotificationTest.java

+4 −10
Original line number Diff line number Diff line
@@ -1249,31 +1249,25 @@ public class NotificationTest { 
    }



    @Test

    @Ignore // TODO: b/329402256 - Restore or delete

    public void testBigPictureStyle_setExtras_pictureIconNull_pictureIconKeyNull() {

    public void testBigPictureStyle_setExtras_pictureIconNull_noPictureIconKey() {

        Notification.BigPictureStyle bpStyle = new Notification.BigPictureStyle();

        bpStyle.bigPicture((Bitmap) null);



        Bundle extras = new Bundle();

        bpStyle.addExtras(extras);



        assertThat(extras.containsKey(EXTRA_PICTURE_ICON)).isTrue();

        final Parcelable pictureIcon = extras.getParcelable(EXTRA_PICTURE_ICON);

        assertThat(pictureIcon).isNull();

        assertThat(extras.containsKey(EXTRA_PICTURE_ICON)).isFalse();

    }



    @Test

    @Ignore // TODO: b/329402256 - Restore or delete

    public void testBigPictureStyle_setExtras_pictureIconNull_pictureKeyNull() {

    public void testBigPictureStyle_setExtras_pictureIconNull_noPictureKey() {

        Notification.BigPictureStyle bpStyle = new Notification.BigPictureStyle();

        bpStyle.bigPicture((Bitmap) null);



        Bundle extras = new Bundle();

        bpStyle.addExtras(extras);



        assertThat(extras.containsKey(EXTRA_PICTURE)).isTrue();

        final Parcelable picture = extras.getParcelable(EXTRA_PICTURE);

        assertThat(picture).isNull();

        assertThat(extras.containsKey(EXTRA_PICTURE)).isFalse();

    }



    @Test