Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 054c430b authored by Nicholas Ambur's avatar Nicholas Ambur Committed by Android (Google) Code Review
Browse files

Merge changes from topic "hotword-unbind-on-destroy" into udc-dev 

* changes:
  AOHD do not unbind HotwordDetectionService on destroy
  unbind from HotwordDetectionService when all sessions are destroyed
parents 0ddef87a ea8b1a55

core/java/android/service/voice/VoiceInteractionService.java

+0 −15
Original line number Diff line number Diff line
@@ -1063,21 +1063,6 @@ public class VoiceInteractionService extends Service { 
                mActiveVisualQueryDetector = null;

            }

            mActiveDetectors.remove(detector);

            shutdownHotwordDetectionServiceIfRequiredLocked();

        }

    }



    private void shutdownHotwordDetectionServiceIfRequiredLocked() {

        for (HotwordDetector detector : mActiveDetectors) {

            if (detector.isUsingSandboxedDetectionService()) {

                return;

            }

        }



        try {

            mSystemService.shutdownHotwordDetectionService();

        } catch (RemoteException e) {

            e.rethrowFromSystemServer();

        }

    }

services/voiceinteraction/java/com/android/server/voiceinteraction/HotwordDetectionConnection.java

+4 −2
Original line number Diff line number Diff line
@@ -913,8 +913,10 @@ final class HotwordDetectionConnection { 
        }

        // Handle case where all hotword detector sessions are destroyed with only the visual

        // detector session left

        if (mDetectorSessions.size() == 1

                && mDetectorSessions.get(0) instanceof VisualQueryDetectorSession) {

        boolean allHotwordDetectionServiceSessionsRemoved = mDetectorSessions.size() == 0

                || (mDetectorSessions.size() == 1 && mDetectorSessions.get(0)

                instanceof VisualQueryDetectorSession);

        if (allHotwordDetectionServiceSessionsRemoved) {

            unbindHotwordDetectionService();

        }

    }