Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0514e02e authored by Lee Shombert's avatar Lee Shombert
Browse files

Only report uncached nulls in PIC 

dumpsys cacheinfo now only reports nulls that are not cached.  This
makes it easier to identify caches that do not cache nulls and which
might benefit from caching nulls.

Flag: EXEMPT bug-fix
Bug: 378762206
Test: atest
 * FrameworksCoreTests:PropertyInvalidatedCacheTests
 * FrameworksCoreTests:IpcDataCacheTest
 * CtsOsTestCases:IpcDataCacheTest
Change-Id: If01b5c73492c9fd626163c9f2ac923f8b7fbab79
parent 24b592ab

core/java/android/app/PropertyInvalidatedCache.java

+4 −7
Original line number Diff line number Diff line
@@ -307,11 +307,8 @@ public class PropertyInvalidatedCache<Query, Result> { 
    @GuardedBy("mLock")

    private long mMisses = 0;



    // This counter tracks the number of times {@link #recompute} returned a null value.  Null

    // results are cached, or not, depending on instantiation arguments.  Caching nulls when they

    // should not be cached is a functional error. Failing to cache nulls that can be cached is a

    // performance error.  A non-zero value here means the cache should be examined to be sure

    // that nulls are correctly cached, or not.

    // This counter tracks the number of times {@link #recompute} returned a null value and the

    // result was not cached.

    @GuardedBy("mLock")

    private long mNulls = 0;
@@ -1728,8 +1725,8 @@ public class PropertyInvalidatedCache<Query, Result> { 
                if (mLastSeenNonce == currentNonce) {

                    if (result != null || mCacheNullResults) {

                        mCache.put(query, result);

                    }

                    if (result == null) {

                    } else if (result == null) {

                        // The result was null and it was not cached.

                        mNulls++;

                    }

                }