Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04d8a730 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "ConnectivityServiceTest: more informative assert failures"

parents 66788dc4 fed512a7

tests/net/java/com/android/server/ConnectivityServiceTest.java

+20 −9
Original line number Diff line number Diff line
@@ -865,7 +865,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        assertNull(mCm.getActiveNetwork());

        assertNull(mCm.getActiveNetworkForUid(Process.myUid()));

        // Test getAllNetworks()

        assertEquals(0, mCm.getAllNetworks().length);

        assertEmpty(mCm.getAllNetworks());

    }



    /**
@@ -906,7 +906,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        mCellNetworkAgent.connect(true);

        waitFor(cv);

        verifyActiveNetwork(TRANSPORT_CELLULAR);

        assertEquals(2, mCm.getAllNetworks().length);

        assertLength(2, mCm.getAllNetworks());

        assertTrue(mCm.getAllNetworks()[0].equals(mCm.getActiveNetwork()) ||

                mCm.getAllNetworks()[1].equals(mCm.getActiveNetwork()));

        assertTrue(mCm.getAllNetworks()[0].equals(mWiFiNetworkAgent.getNetwork()) ||
@@ -916,7 +916,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        mWiFiNetworkAgent.connect(true);

        waitFor(cv);

        verifyActiveNetwork(TRANSPORT_WIFI);

        assertEquals(2, mCm.getAllNetworks().length);

        assertLength(2, mCm.getAllNetworks());

        assertTrue(mCm.getAllNetworks()[0].equals(mCm.getActiveNetwork()) ||

                mCm.getAllNetworks()[1].equals(mCm.getActiveNetwork()));

        assertTrue(mCm.getAllNetworks()[0].equals(mCellNetworkAgent.getNetwork()) ||
@@ -924,9 +924,9 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        // Test cellular linger timeout.

        waitFor(mCellNetworkAgent.getDisconnectedCV());

        waitForIdle();

        assertEquals(1, mCm.getAllNetworks().length);

        assertLength(1, mCm.getAllNetworks());

        verifyActiveNetwork(TRANSPORT_WIFI);

        assertEquals(1, mCm.getAllNetworks().length);

        assertLength(1, mCm.getAllNetworks());

        assertEquals(mCm.getAllNetworks()[0], mCm.getActiveNetwork());

        // Test WiFi disconnect.

        cv = waitForConnectivityBroadcasts(1);
@@ -1855,7 +1855,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        mCellNetworkAgent.connectWithoutInternet();

        waitFor(cv);

        waitForIdle();

        assertEquals(0, mCm.getAllNetworks().length);

        assertEmpty(mCm.getAllNetworks());

        verifyNoNetwork();



        // Test bringing up validated WiFi.
@@ -2529,7 +2529,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        assertTrue(testFactory.getMyStartRequested());



        // Bring up cell data and check that the factory stops looking.

        assertEquals(1, mCm.getAllNetworks().length);

        assertLength(1, mCm.getAllNetworks());

        mCellNetworkAgent = new MockNetworkAgent(TRANSPORT_CELLULAR);

        testFactory.expectAddRequests(2);  // Because the cell request changes score twice.

        mCellNetworkAgent.connect(true);
@@ -2540,7 +2540,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        // Check that cell data stays up.

        waitForIdle();

        verifyActiveNetwork(TRANSPORT_WIFI);

        assertEquals(2, mCm.getAllNetworks().length);

        assertLength(2, mCm.getAllNetworks());



        // Turn off mobile data always on and expect the request to disappear...

        testFactory.expectRemoveRequests(1);
@@ -2549,7 +2549,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 


        // ...  and cell data to be torn down.

        cellNetworkCallback.expectCallback(CallbackState.LOST, mCellNetworkAgent);

        assertEquals(1, mCm.getAllNetworks().length);

        assertLength(1, mCm.getAllNetworks());



        testFactory.unregister();

        mCm.unregisterNetworkCallback(cellNetworkCallback);
@@ -3238,4 +3238,15 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
            mCm.unregisterNetworkCallback(pendingIntent);

        }

    }



    private static <T> void assertEmpty(T[] ts) {

        int length = ts.length;

        assertEquals("expected empty array, but length was " + length, 0, length);

    }



    private static <T> void assertLength(int expected, T[] got) {

        int length = got.length;

        assertEquals(String.format("expected array of length %s, but length was %s for %s",

                expected, length, Arrays.toString(got)), expected, length);

    }

}