Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0478260b authored by Kiran Ramachandra's avatar Kiran Ramachandra Committed by Android (Google) Code Review
Browse files

Merge "DO NOT MERGE Ignore - Sanitized uri scheme by removing scheme delimiter" into tm-dev

parents 338f22f4 841ce92a

core/java/android/net/Uri.java

+5 −1
Original line number Diff line number Diff line
@@ -1388,7 +1388,11 @@ public abstract class Uri implements Parcelable, Comparable<Uri> { 
         * @param scheme name or {@code null} if this is a relative Uri

         */

        public Builder scheme(String scheme) {

            this.scheme = scheme;

            if (scheme != null) {

                this.scheme = scheme.replace("://", "");

            } else {

                this.scheme = null;

            }

            return this;

        }

core/tests/coretests/src/android/net/UriTest.java

+11 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package android.net; 


import android.content.ContentUris;

import android.os.Parcel;

import android.platform.test.annotations.AsbSecurityTest;



import androidx.test.filters.SmallTest;
@@ -88,6 +89,16 @@ public class UriTest extends TestCase { 
        assertNull(u.getHost());

    }



    @AsbSecurityTest(cveBugId = 261721900)

    @SmallTest

    public void testSchemeSanitization() {

        Uri uri = new Uri.Builder()

                .scheme("http://https://evil.com:/te:st/")

                .authority("google.com").path("one/way").build();

        assertEquals("httphttpsevil.com:/te:st/", uri.getScheme());

        assertEquals("httphttpsevil.com:/te:st/://google.com/one/way", uri.toString());

    }



    @SmallTest

    public void testStringUri() {

        assertEquals("bob lee",