Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0310424e authored by Josep del Rio's avatar Josep del Rio
Browse files

Remove Meta+T shortcut 

At the moment there is no way to interact with a open taskbar from
shortcut, so it has been decided to remove this shortcut for now.

Bug: 311676243
Flag: NA
Test: Flashed on device
Change-Id: I9c30335c28c96a2fe47cb5a4c355e4a68c44cee6
parent 1836f6d4

packages/SystemUI/res/values/strings.xml

+0 −2
Original line number Diff line number Diff line
@@ -1991,8 +1991,6 @@ 
    <string name="group_system_cycle_back">Cycle backward through recent apps</string>

    <!-- User visible title for the keyboard shortcut that accesses list of all apps and search. [CHAR LIMIT=70] -->

    <string name="group_system_access_all_apps_search">Open apps list</string>

    <!-- User visible title for the keyboard shortcut that hides and (re)showes taskbar. [CHAR LIMIT=70] -->

    <string name="group_system_hide_reshow_taskbar">Show taskbar</string>

    <!-- User visible title for the keyboard shortcut that accesses [system] settings. [CHAR LIMIT=70] -->

    <string name="group_system_access_system_settings">Open settings</string>

    <!-- User visible title for the keyboard shortcut that accesses Assistant app. [CHAR LIMIT=70] -->

packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcutListSearch.java

+0 −5
Original line number Diff line number Diff line
@@ -560,11 +560,6 @@ public final class KeyboardShortcutListSearch { 
                                Pair.create(

                                        KeyEvent.KEYCODE_TAB,

                                        KeyEvent.META_SHIFT_ON | KeyEvent.META_ALT_ON))),

                /* Hide and (re)show taskbar: Meta + T */

                new ShortcutKeyGroupMultiMappingInfo(

                        context.getString(R.string.group_system_hide_reshow_taskbar),

                        Arrays.asList(

                                Pair.create(KeyEvent.KEYCODE_T, KeyEvent.META_META_ON))),

                /* Access notification shade: Meta + N */

                new ShortcutKeyGroupMultiMappingInfo(

                        context.getString(R.string.group_system_access_notification_shade),

services/core/java/com/android/server/policy/PhoneWindowManager.java

+0 −7
Original line number Diff line number Diff line
@@ -3478,13 +3478,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
                    return true;

                }

                break;

            case KeyEvent.KEYCODE_T:

                if (firstDown && event.isMetaPressed()) {

                    toggleTaskbar();

                    logKeyboardSystemsEvent(event, KeyboardLogEvent.TOGGLE_TASKBAR);

                    return true;

                }

                break;

            case KeyEvent.KEYCODE_DEL:

            case KeyEvent.KEYCODE_ESCAPE:

                if (firstDown && event.isMetaPressed()) {

services/tests/wmtests/src/com/android/server/policy/ShortcutLoggingTests.java

+0 −2
Original line number Diff line number Diff line
@@ -95,8 +95,6 @@ public class ShortcutLoggingTests extends ShortcutKeyTestBase { 
                        new int[]{KeyEvent.KEYCODE_NOTIFICATION},

                        KeyboardLogEvent.TOGGLE_NOTIFICATION_PANEL, KeyEvent.KEYCODE_NOTIFICATION,

                        0},

                {"Meta + T -> Toggle Taskbar", new int[]{META_KEY, KeyEvent.KEYCODE_T},

                        KeyboardLogEvent.TOGGLE_TASKBAR, KeyEvent.KEYCODE_T, META_ON},

                {"Meta + Ctrl + S -> Take Screenshot",

                        new int[]{META_KEY, CTRL_KEY, KeyEvent.KEYCODE_S},

                        KeyboardLogEvent.TAKE_SCREENSHOT, KeyEvent.KEYCODE_S, META_ON | CTRL_ON},