Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02f8f9c8 authored by Hugo Benichi's avatar Hugo Benichi
Browse files

ConnectivityServiceTest: more tweaks to testRequestBenchmark 

Recent continuous testing runs indicates that commit 849b81b7 did not
completely fixed the issue with testRequestBenchmark.

This patch changes the name of the test to not include "test" and
removes @SmallTest annotation, which should do the job of @Ignore while
ConnectivityServiceTest still extends AndroidTestCase.

In addition timeouts are adjusted to take into account recent failures
observed.

This is the last pending action before turning on FrameworksNetTests on
presubmits.

Bug: 32561414
Test: no functional change
Change-Id: I56ef334e19e99e5a3483418330e5f0ccd6eb31bb
parent 6cdcba7b

tests/net/java/com/android/server/ConnectivityServiceTest.java

+4 −5
Original line number Diff line number Diff line
@@ -2411,8 +2411,7 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
    }



    @Ignore // This test has instrinsic chances of spurious failures: ignore for continuous testing.

    @SmallTest

    public void testRequestBenchmark() throws Exception {

    public void benchmarkRequestRegistrationAndCallbackDispatch() throws Exception {

        // TODO: turn this unit test into a real benchmarking test.

        // Benchmarks connecting and switching performance in the presence of a large number of

        // NetworkRequests.
@@ -2422,9 +2421,9 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        //    and NUM_REQUESTS onAvailable callbacks to fire.

        // See how long it took.

        final int NUM_REQUESTS = 90;

        final int REGISTER_TIME_LIMIT_MS = 180;

        final int CONNECT_TIME_LIMIT_MS = 50;

        final int SWITCH_TIME_LIMIT_MS = 50;

        final int REGISTER_TIME_LIMIT_MS = 200;

        final int CONNECT_TIME_LIMIT_MS = 60;

        final int SWITCH_TIME_LIMIT_MS = 60;

        final int UNREGISTER_TIME_LIMIT_MS = 20;



        final NetworkRequest request = new NetworkRequest.Builder().clearCapabilities().build();