Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02e668b7 authored by Yu Chao's avatar Yu Chao
Browse files

Fix flaky test for VolumeDialogImplTest. 

We only care about whether or not the show/dismiss signals are sent. The
invocation times should be irrelevant.

Test: VolumeDialogImplTest
Bug: 347128147
Flag: com.android.systemui.enable_contextual_tip_for_mute_volume
Change-Id: Ie389b723e3e9ff58de8d90e24f8c93db47d14f7d
parent c92aa737

packages/SystemUI/tests/src/com/android/systemui/volume/VolumeDialogImplTest.java

+3 −2
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ import static org.junit.Assume.assumeNotNull; 
import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.Mockito.atLeastOnce;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.reset;

import static org.mockito.Mockito.times;
@@ -783,8 +784,8 @@ public class VolumeDialogImplTest extends SysuiTestCase { 
        mDialog.show(SHOW_REASON_UNKNOWN);

        mTestableLooper.processAllMessages();



        verify(mVolumeDialogInteractor).onDialogShown();

        verify(mVolumeDialogInteractor).onDialogDismissed(); // dismiss by timeout

        verify(mVolumeDialogInteractor, atLeastOnce()).onDialogShown();

        verify(mVolumeDialogInteractor, atLeastOnce()).onDialogDismissed(); // dismiss by timeout

    }



    /**