Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02c59f00 authored by Chris Li's avatar Chris Li
Browse files

Fix ExitPipWithDismissButtonTest#focusDoesNotChange 

The transition is to click on the pip menu, then click on the dismiss
button. This will cause the focus change.

Fix: 215869110
Fix: 216306753
Test: atest WMShellFlickerTests:ExitPipWithDismissButtonTest
Change-Id: I50dab84f588c3bedaa7d65c02144054d4eefdcd5
parent 9ab79ba4

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ExitPipTransition.kt

+0 −11
Original line number Diff line number Diff line
@@ -93,15 +93,4 @@ abstract class ExitPipTransition(testSpec: FlickerTestParameter) : PipTransition 
                .isVisible(LAUNCHER_COMPONENT)

        }

    }



    /**

     * Checks that the focus doesn't change between windows during the transition

     */

    @Presubmit

    @Test

    open fun focusDoesNotChange() {

        testSpec.assertEventLog {

            this.focusDoesNotChange()

        }

    }

}

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ExitPipWithDismissButtonTest.kt

+11 −3
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.wm.shell.flicker.pip



import android.platform.test.annotations.Presubmit

import android.view.Surface

import androidx.test.filters.FlakyTest

import androidx.test.filters.RequiresDevice
@@ -72,10 +73,17 @@ class ExitPipWithDismissButtonTest(testSpec: FlickerTestParameter) : ExitPipTran 
    @Test

    override fun statusBarLayerRotatesScales() = super.statusBarLayerRotatesScales()



    /** {@inheritDoc}  */

    @FlakyTest(bugId = 215869110)

    /**

     * Checks that the focus changes between the pip menu window and the launcher when clicking the

     * dismiss button on pip menu to close the pip window.

     */

    @Presubmit

    @Test

    override fun focusDoesNotChange() = super.focusDoesNotChange()

    fun focusDoesNotChange() {

        testSpec.assertEventLog {

            this.focusChanges("PipMenuView", "NexusLauncherActivity")

        }

    }



    companion object {

        /**

libs/WindowManager/Shell/tests/flicker/src/com/android/wm/shell/flicker/pip/ExitPipWithSwipeDownTest.kt

+12 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.wm.shell.flicker.pip



import android.platform.test.annotations.Presubmit

import android.view.Surface

import androidx.test.filters.FlakyTest

import androidx.test.filters.RequiresDevice
@@ -81,6 +82,17 @@ class ExitPipWithSwipeDownTest(testSpec: FlickerTestParameter) : ExitPipTransiti 
    @Test

    override fun statusBarLayerRotatesScales() = testSpec.statusBarLayerRotatesScales()



    /**

     * Checks that the focus doesn't change between windows during the transition

     */

    @Presubmit

    @Test

    fun focusDoesNotChange() {

        testSpec.assertEventLog {

            this.focusDoesNotChange()

        }

    }



    companion object {

        /**

         * Creates the test configurations.