Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02c4c8a7 authored by Jim Miller's avatar Jim Miller
Browse files

Fix 5288804: Make music trasports in lockscreen more closely match design 

This fixes three issues;
- Make the background black while the transport is showing.
- Show scrim sandwiched between artwork and overlapping UI.
- Remove gaps in sides of background assets.

Change-Id: I563fc680c4c042d8b25ec37332aeab528cf838ca
parent 3f70aa78

core/res/res/drawable-hdpi/ic_lockscreen_player_background.9.png

−114 B (129 B)
Loading image diff...

core/res/res/drawable-mdpi/ic_lockscreen_player_background.9.png

−112 B (118 B)
Loading image diff...

core/res/res/drawable-xhdpi/ic_lockscreen_player_background.9.png

−101 B (144 B)
Loading image diff...

core/res/res/layout/keyguard_transport_control.xml

+13 −8
Original line number Diff line number Diff line
@@ -19,9 +19,14 @@ 
     but rather as include tags for this file or the layout will break. -->

<com.android.internal.widget.TransportControlView

    xmlns:android="http://schemas.android.com/apk/res/android"

    android:id="@+id/transport_controls"

    android:background="@drawable/ic_lockscreen_player_background">

    android:id="@+id/transport_controls">



    <!-- FrameLayout used as scrim to show between album art and buttons -->

    <FrameLayout

        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:foreground="@drawable/ic_lockscreen_player_background">

        <!-- We use ImageView for its cropping features, otherwise could be android:background -->

        <ImageView

            android:id="@+id/albumart"

            android:layout_width="match_parent"
@@ -30,12 +35,12 @@ 
            android:scaleType="centerCrop"

            android:adjustViewBounds="false"

        />

    </FrameLayout>



    <LinearLayout

        android:orientation="vertical"

        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:background="#c8000000"

        android:layout_gravity="bottom">

        <TextView

            android:id="@+id/title"

policy/src/com/android/internal/policy/impl/LockPatternKeyguardView.java

+6 −0
Original line number Diff line number Diff line
@@ -42,8 +42,10 @@ import android.content.res.Resources; 
import android.content.ServiceConnection;

import android.graphics.Bitmap;

import android.graphics.Canvas;

import android.graphics.Color;

import android.graphics.ColorFilter;

import android.graphics.PixelFormat;

import android.graphics.drawable.ColorDrawable;

import android.graphics.drawable.Drawable;

import android.os.Bundle;

import android.os.Handler;
@@ -241,6 +243,9 @@ public class LockPatternKeyguardView extends KeyguardViewBase implements Handler 


            // TODO: examine all widgets to derive clock status

            mUpdateMonitor.reportClockVisible(false);



            // TODO: We should disable the wallpaper instead

            setBackgroundColor(0xff000000);

        }



        public void requestHide(View view) {
@@ -249,6 +254,7 @@ public class LockPatternKeyguardView extends KeyguardViewBase implements Handler 


            // TODO: examine all widgets to derive clock status

            mUpdateMonitor.reportClockVisible(true);

            setBackgroundDrawable(null);

        }



        public boolean isVisible(View self) {