Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02bbbc11 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick Committed by Android Git Automerger
Browse files

am 069e810c: Merge "Fixing memory leak in PreferenceScreen."

* commit '069e810c':
  Fixing memory leak in PreferenceScreen.
parents 4bb180d6 069e810c
Loading
Loading
Loading
Loading
+8 −3
Original line number Diff line number Diff line
@@ -81,6 +81,8 @@ public final class PreferenceScreen extends PreferenceGroup implements AdapterVi
    
    private Dialog mDialog;

    private ListView mListView;
    
    /**
     * Do NOT use this constructor, use {@link PreferenceManager#createPreferenceScreen(Context)}.
     * @hide-
@@ -145,15 +147,18 @@ public final class PreferenceScreen extends PreferenceGroup implements AdapterVi
    
    private void showDialog(Bundle state) {
        Context context = getContext();
        ListView listView = new ListView(context);
        bind(listView);
        if (mListView != null) {
            mListView.setAdapter(null);
        }
        mListView = new ListView(context);
        bind(mListView);

        // Set the title bar if title is available, else no title bar
        final CharSequence title = getTitle();
        Dialog dialog = mDialog = new Dialog(context, TextUtils.isEmpty(title)
                ? com.android.internal.R.style.Theme_NoTitleBar
                : com.android.internal.R.style.Theme);
        dialog.setContentView(listView);
        dialog.setContentView(mListView);
        if (!TextUtils.isEmpty(title)) {
            dialog.setTitle(title);
        }