Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02917dd5 authored by Daniel Nishi's avatar Daniel Nishi
Browse files

Remove the cache size from internal size. 

Because the system can automatically clear away cache data, we remove
usage of it from the list of app storage usage in Settings. This should
encourage developers to more aggressively use the unattributed cache,
rather than the attributed regular data folder.

This affects the following fields on the AppEntry: internalSize & str
and size & sizeStr (which are derived from the internal size).

Currently, ApplicationsState.AppEntry.internalSize, externalSize, and
size are only used in the Settings apps so this shouldn't have broader
implications.

Test: Manual verification of Other Apps page
Fixes: 131152171
Change-Id: I3eb2e28701490a543c633e9c95a280059bb99c21
parent 2d1d3248

packages/SettingsLib/src/com/android/settingslib/applications/ApplicationsState.java

+4 −2
Original line number Diff line number Diff line
@@ -707,7 +707,9 @@ public class ApplicationsState { 


    private long getTotalInternalSize(PackageStats ps) {

        if (ps != null) {

            return ps.codeSize + ps.dataSize;

            // We subtract the cache size because the system can clear it automatically and

            // |dataSize| is a superset of |cacheSize|.

            return ps.codeSize + ps.dataSize - ps.cacheSize;

        }

        return SIZE_INVALID;

    }
@@ -715,7 +717,7 @@ public class ApplicationsState { 
    private long getTotalExternalSize(PackageStats ps) {

        if (ps != null) {

            // We also include the cache size here because for non-emulated

            // we don't automtically clean cache files.

            // we don't automatically clean cache files.

            return ps.externalCodeSize + ps.externalDataSize

                    + ps.externalCacheSize

                    + ps.externalMediaSize + ps.externalObbSize;

packages/SettingsLib/tests/robotests/src/com/android/settingslib/applications/ApplicationsStateRoboTest.java

+2 −1
Original line number Diff line number Diff line
@@ -191,8 +191,9 @@ public class ApplicationsStateRoboTest { 
        shadowContext.setSystemService(Context.STORAGE_STATS_SERVICE, mStorageStatsManager);

        StorageStats storageStats = new StorageStats();

        storageStats.codeBytes = 10;

        storageStats.dataBytes = 20;

        storageStats.cacheBytes = 30;

        // Data bytes are a superset of cache bytes.

        storageStats.dataBytes = storageStats.cacheBytes + 20;

        when(mStorageStatsManager.queryStatsForPackage(any(UUID.class),

            anyString(), any(UserHandle.class))).thenReturn(storageStats);