Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02427550 authored by Charles Chen's avatar Charles Chen
Browse files

Remove WMG#closeAll in WindowTokenClient 

The non-activity window should be managed by the application itself.
Framework side doesn't need to handle it.
Also apps may remove the view after WMG#closeAll and cause
IllegalArgumentException "not attached to window manager".

Test: atest WindowContextTest
Test: atest WindowContextTests WindowContextPolicyTests
Bug: 183251523
Change-Id: I15ccb9a129f541f3be9733e8cd6121bb4c0fd6b8
parent c22aff4e

core/java/android/window/WindowTokenClient.java

+0 −6
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ import android.content.Context; 
import android.content.res.Configuration;

import android.os.Bundle;

import android.os.IBinder;

import android.view.WindowManagerGlobal;



import java.lang.ref.WeakReference;
@@ -94,10 +93,5 @@ public class WindowTokenClient extends IWindowToken.Stub { 
            context.destroy();

            mContextRef.clear();

        }

        ActivityThread.currentActivityThread().getHandler().post(() -> {

            // If the tracked window token is detached, release all views attached to this token.

            WindowManagerGlobal.getInstance().closeAll(WindowTokenClient.this,

                    "#onWindowTokenRemoved()", "WindowTokenClient");

        });

    }

}