Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01f18563 authored by Colin Cross's avatar Colin Cross
Browse files

Re-enable -Wall and -Werror that were lost in a merge 

-Wall and -Werror were lost during a merge when they were added to
aaptCFLAGS instead of aaptCFlags.  Fix the typo, and the warnings
that crept in while it was disabled.

Change-Id: Ib944b8d6149278e4f3861c1acac277bcd95cc7c2
parent dbd9a4b6

tools/aapt/Android.mk

+1 −1
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ aaptHostStaticLibs := \ 
    libziparchive-host



aaptCFlags := -DAAPT_VERSION=\"$(BUILD_NUMBER)\"

aaptCFLAGS += -Wall -Werror

aaptCFlags += -Wall -Werror



ifeq ($(HOST_OS),linux)

    aaptHostLdLibs += -lrt -ldl -lpthread

tools/aapt/Images.cpp

+0 −1
Original line number Diff line number Diff line
@@ -412,7 +412,6 @@ static void find_max_opacity(png_byte** rows, 
                             int startX, int startY, int endX, int endY, int dX, int dY,

                             int* out_inset)

{

    bool opaque_within_inset = true;

    uint8_t max_opacity = 0;

    int inset = 0;

    *out_inset = 0;

tools/aapt/Resource.cpp

+0 −1
Original line number Diff line number Diff line
@@ -3056,7 +3056,6 @@ writeProguardForLayouts(ProguardKeepSet* keep, const sp<AaptAssets>& assets) 
        const sp<AaptDir>& d = dirs.itemAt(k);

        const String8& dirName = d->getLeaf();

        Vector<String8> startTags;

        const char* startTag = NULL;

        const KeyedVector<String8, Vector<NamespaceAttributePair> >* tagAttrPairs = NULL;

        if ((dirName == String8("layout")) || (strncmp(dirName.string(), "layout-", 7) == 0)) {

            tagAttrPairs = &kLayoutTagAttrPairs;

tools/aapt/ResourceTable.cpp

+1 −2
Original line number Diff line number Diff line
@@ -3167,7 +3167,7 @@ status_t ResourceTable::flatten(Bundle* bundle, const sp<const ResourceFilter>& 
                    if (!validResources[i]) {

                        sp<ConfigList> c = t->getOrderedConfigs().itemAt(i);

                        if (c != NULL) {

                            fprintf(stderr, "%s: no entries written for %s/%s (0x%08x)\n", log_prefix,

                            fprintf(stderr, "%s: no entries written for %s/%s (0x%08zx)\n", log_prefix,

                                    String8(typeName).string(), String8(c->getName()).string(),

                                    Res_MAKEID(p->getAssignedId() - 1, ti, i));

                        }
@@ -4526,7 +4526,6 @@ status_t ResourceTable::modifyForCompat(const Bundle* bundle) { 
                    const KeyedVector<String16, Item>& bag = e->getBag();

                    const size_t bagCount = bag.size();

                    for (size_t bi = 0; bi < bagCount; bi++) {

                        const Item& item = bag.valueAt(bi);

                        const uint32_t attrId = getResId(bag.keyAt(bi), &attr16);

                        const int sdkLevel = getPublicAttributeSdkLevel(attrId);

                        if (sdkLevel > 1 && sdkLevel > config.sdkVersion && sdkLevel > minSdk) {