Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01c19615 authored by Linus Tufvesson's avatar Linus Tufvesson
Browse files

Make PI created by AlertWindowNotification immutable 

Bug: 153654357
Test: Verfied with PoC app that it is no longer possible to redirect the
PendingIntent

Change-Id: I65fcb24453be1dbcebe6690ffbb7030c87ba907f
parent b1215125

services/core/java/com/android/server/wm/AlertWindowNotification.java

+3 −1
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.server.wm; 


import static android.app.NotificationManager.IMPORTANCE_MIN;

import static android.app.PendingIntent.FLAG_CANCEL_CURRENT;

import static android.app.PendingIntent.FLAG_IMMUTABLE;

import static android.content.Context.NOTIFICATION_SERVICE;

import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TASK;

import static android.content.Intent.FLAG_ACTIVITY_NEW_TASK;
@@ -139,7 +140,8 @@ class AlertWindowNotification { 
                Uri.fromParts("package", packageName, null));

        intent.setFlags(FLAG_ACTIVITY_NEW_TASK | FLAG_ACTIVITY_CLEAR_TASK);

        // Calls into activity manager...

        return PendingIntent.getActivity(context, mRequestCode, intent, FLAG_CANCEL_CURRENT);

        return PendingIntent.getActivity(context, mRequestCode, intent,

                FLAG_CANCEL_CURRENT | FLAG_IMMUTABLE);

    }



    private void createNotificationChannel(Context context, String appName) {