Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0149739c authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixed an issue where notification groups could be empty 

Because we were looking at the theoretical and not the actual
showing public state, notifications could get updated to
invisible without ever recovering.
The actual showingPublic state now determins the visibility.

Fixes: 117272628
Test: add low priority child while group is on lockscreen and invisible
Change-Id: Iacdd984451a2e3d69a0aaa8186b6afab5447188e
parent f4d73340

packages/SystemUI/src/com/android/systemui/statusbar/notification/row/ExpandableNotificationRow.java

+2 −2
Original line number Diff line number Diff line
@@ -2021,10 +2021,10 @@ public class ExpandableNotificationRow extends ActivatableNotificationView 
    private void updateChildrenVisibility() {

        boolean hideContentWhileLaunching = mExpandAnimationRunning && mGuts != null

                && mGuts.isExposed();

        mPrivateLayout.setVisibility(!shouldShowPublic() && !mIsSummaryWithChildren

        mPrivateLayout.setVisibility(!mShowingPublic && !mIsSummaryWithChildren

                && !hideContentWhileLaunching ? VISIBLE : INVISIBLE);

        if (mChildrenContainer != null) {

            mChildrenContainer.setVisibility(!shouldShowPublic() && mIsSummaryWithChildren

            mChildrenContainer.setVisibility(!mShowingPublic && mIsSummaryWithChildren

                    && !hideContentWhileLaunching ? VISIBLE

                    : INVISIBLE);

        }