Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 010aa30b authored by Michael Wright's avatar Michael Wright
Browse files

Fix erroneous self comparison in KeyValueBackupTaskTest 

Bug: 217923092
Test: atest BackupFrameworksServicesRoboTests
Change-Id: I73c88df39b63b40a6ed008c5e7872604a5894fbc
parent 0f654a9f

services/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ java_defaults { 
            // "-Xep:AndroidFrameworkBinderIdentity:ERROR",

            "-Xep:AndroidFrameworkCompatChange:ERROR",

            // "-Xep:AndroidFrameworkUid:ERROR",

            "-Xep:SelfEquals:ERROR",

            // NOTE: only enable to generate local patchfiles

            // "-XepPatchChecks:refaster:frameworks/base/errorprone/refaster/EfficientXml.java.refaster",

            // "-XepPatchLocation:/tmp/refaster/",

services/robotests/backup/src/com/android/server/backup/keyvalue/KeyValueBackupTaskTest.java

+1 −1
Original line number Diff line number Diff line
@@ -2727,7 +2727,7 @@ public class KeyValueBackupTaskTest { 
        // The second line will throw NPE because it will call lambda 1 with null, since argThat()

        // returns null. So we guard against that by checking for null.

        return packageInfo ->

                packageInfo != null && packageInfo.packageName.equals(packageInfo.packageName);

                packageInfo != null && packageInfo.packageName.equals(packageData.packageName);

    }



    /** Matches {@link ApplicationInfo} whose package name is {@code packageData.packageName}. */