Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00708abf authored Feb 09, 2017 by Selim Cinek

The transformhelper now also transforms gone views

Because a notification's views could change from GONE
to VISIBLE without notifying the transformhelper, we're
now adding the transformed views even if they are gone
at the resolution time.
This fixes a bug where the Time would fade in / out
properly.

This also fixes another bug where the time could remain
invisible.

Test: add notification group without any header text and observe smooth fading when expanding group
Change-Id: I1d6b0126df1550a71baa2e7729bdf9664b934b02
Fixes: 35127160

parent 87ed69bd

packages/SystemUI/src/com/android/systemui/statusbar/ViewTransformationHelper.java

+0 −3

Original line number	Diff line number	Diff line
		@@ -224,9 +224,6 @@ public class ViewTransformationHelper implements TransformableView {
		stack.push(viewRoot);
		while (!stack.isEmpty()) {
		View child = stack.pop();
		if (child.getVisibility() == View.GONE) {
		continue;
		}
		Boolean containsView = (Boolean) child.getTag(TAG_CONTAINS_TRANSFORMED_VIEW);
		if (containsView == null) {
		// This one is unhandled, let's add it to our list.

packages/SystemUI/src/com/android/systemui/statusbar/notification/TransformState.java

+2 −1

Original line number	Diff line number	Diff line
		@@ -69,7 +69,8 @@ public class TransformState {
		public void transformViewFrom(TransformState otherState, float transformationAmount) {
		mTransformedView.animate().cancel();
		if (sameAs(otherState)) {
		if (mTransformedView.getVisibility() == View.INVISIBLE) {
		if (mTransformedView.getVisibility() == View.INVISIBLE
		\|\| mTransformedView.getAlpha() != 1.0f) {
		// We have the same content, lets show ourselves
		mTransformedView.setAlpha(1.0f);
		mTransformedView.setVisibility(View.VISIBLE);