Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 005f7cf1 authored by Adam Cohen's avatar Adam Cohen
Browse files

Remove problematic early return from notifyDataSetChanged 

-> If connection to the service fails for whatever reason,
mNotifyDataSetChangedAfterOnServiceConnected can get stuck to true, preventing
future connections to the service. Don't let this prevent from connecting to the
service.

issue 19890339

Change-Id: I376101ae146359109df53add3a3202ba2e1e842d
parent d9743805

core/java/android/widget/RemoteViewsAdapter.java

+0 −4
Original line number Diff line number Diff line
@@ -1335,10 +1335,6 @@ public class RemoteViewsAdapter extends BaseAdapter implements Handler.Callback 
        // If we are not connected, queue up the notifyDataSetChanged to be handled when we do

        // connect

        if (!mServiceConnection.isConnected()) {

            if (mNotifyDataSetChangedAfterOnServiceConnected) {

                return;

            }



            mNotifyDataSetChangedAfterOnServiceConnected = true;

            requestBindService();

            return;