Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 003db4e4 authored by Derek Sollenberger's avatar Derek Sollenberger
Browse files

Reduce number of unique paths used when drawing the battery icon. 

By clipping the canvas instead of the path we can avoid both the
computation of the new path on the UI Thread and get cache reuse
of the existing path on the RenderThread.

Bug: 64487466
Test: SystemUiJankTests#testNotificationListPull
Change-Id: Ic237aa1bc6b50b452eb9c71e23748b5d454dfa3c
parent 0516e16e

packages/SettingsLib/src/com/android/settingslib/graph/BatteryMeterDrawableBase.java

+3 −4
Original line number Diff line number Diff line
@@ -90,7 +90,6 @@ public class BatteryMeterDrawableBase extends Drawable { 
    private final RectF mPlusFrame = new RectF();



    private final Path mShapePath = new Path();

    private final Path mClipPath = new Path();

    private final Path mTextPath = new Path();



    public BatteryMeterDrawableBase(Context context, int frameColor) {
@@ -429,10 +428,10 @@ public class BatteryMeterDrawableBase extends Drawable { 


        // draw the battery shape, clipped to charging level

        mFrame.top = levelTop;

        mClipPath.reset();

        mClipPath.addRect(mFrame, Path.Direction.CCW);

        mShapePath.op(mClipPath, Path.Op.INTERSECT);

        c.save();

        c.clipRect(mFrame);

        c.drawPath(mShapePath, mBatteryPaint);

        c.restore();



        if (!mCharging && !mPowerSaveEnabled) {

            if (level <= mCriticalLevel) {