Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00029af7 authored by Muhammad Qureshi's avatar Muhammad Qureshi
Browse files

Revert "Revert "Revert "Introduce initOrder for apex-system-services.""" 

This reverts commit 5a383858.

Reason for revert: DroidMonitor: Potential culprit for Bug 217580573 - verified through ABTD:
https://android-build.googleplex.com/builds/abtd/run/L65800000952890870

Change-Id: Ib9fdb4af623c93cd445d1031e57716b1df0f708e
parent 5a383858

core/res/res/values/attrs_manifest.xml

+0 −8
Original line number Diff line number Diff line
@@ -2839,14 +2839,6 @@ 
        <attr name="path" />

        <attr name="minSdkVersion" />

        <attr name="maxSdkVersion" />

        <!-- The order in which the apex system services are initiated. When there are dependencies

        among apex system services, setting this attribute for each of them ensures that they are

        created in the order required by those dependencies. The apex-system-services that are

        started manually within SystemServer ignore the initOrder and are not considered for

        automatic starting of the other services.

        The value is a simple integer, with higher number being initialized first. If not specified,

        the default order is 0. -->

        <attr name="initOrder" format="integer" />

    </declare-styleable>



    <!-- The <code>receiver</code> tag declares an

services/core/java/com/android/server/pm/ApexManager.java

+14 −21
Original line number Diff line number Diff line
@@ -32,6 +32,9 @@ import android.content.pm.PackageInfo; 
import android.content.pm.PackageInstaller;

import android.content.pm.PackageManager;

import android.content.pm.SigningDetails;

import com.android.server.pm.pkg.parsing.PackageInfoWithoutStateUtils;

import com.android.server.pm.pkg.parsing.ParsingPackageUtils;

import com.android.server.pm.pkg.component.ParsedApexSystemService;

import android.content.pm.parsing.result.ParseResult;

import android.content.pm.parsing.result.ParseTypeImpl;

import android.os.Binder;
@@ -56,9 +59,6 @@ import com.android.modules.utils.build.UnboundedSdkLevel; 
import com.android.server.pm.parsing.PackageParser2;

import com.android.server.pm.parsing.pkg.AndroidPackage;

import com.android.server.pm.parsing.pkg.ParsedPackage;

import com.android.server.pm.pkg.component.ParsedApexSystemService;

import com.android.server.pm.pkg.parsing.PackageInfoWithoutStateUtils;

import com.android.server.pm.pkg.parsing.ParsingPackageUtils;

import com.android.server.utils.TimingsTraceAndSlog;



import com.google.android.collect.Lists;
@@ -414,11 +414,9 @@ public abstract class ApexManager { 
            throws PackageManagerException;



    /**

     * Get a list of apex system services implemented in an apex.

     *

     * <p>The list is sorted by initOrder for consistency.

     * Get a map of system services defined in an apex mapped to the jar files they reside in.

     */

    public abstract List<ApexSystemServiceInfo> getApexSystemServices();

    public abstract Map<String, String> getApexSystemServices();



    /**

     * Dumps various state information to the provided {@link PrintWriter} object.
@@ -451,7 +449,7 @@ public abstract class ApexManager { 
         * Map of all apex system services to the jar files they are contained in.

         */

        @GuardedBy("mLock")

        private List<ApexSystemServiceInfo> mApexSystemServices = new ArrayList<>();

        private Map<String, String> mApexSystemServices = new ArrayMap<>();



        /**

         * Contains the list of {@code packageName}s of apks-in-apex for given
@@ -607,19 +605,14 @@ public abstract class ApexManager { 
                        }



                        String name = service.getName();

                        for (ApexSystemServiceInfo info : mApexSystemServices) {

                            if (info.getName().equals(name)) {

                        if (mApexSystemServices.containsKey(name)) {

                            throw new IllegalStateException(String.format(

                                    "Duplicate apex-system-service %s from %s, %s",

                                        name, info.mJarPath, service.getJarPath()));

                            }

                                    name, mApexSystemServices.get(name), service.getJarPath()));

                        }



                        ApexSystemServiceInfo info = new ApexSystemServiceInfo(

                                service.getName(), service.getJarPath(), service.getInitOrder());

                        mApexSystemServices.add(info);

                        mApexSystemServices.put(name, service.getJarPath());

                    }

                    Collections.sort(mApexSystemServices);

                    mPackageNameToApexModuleName.put(packageInfo.packageName, ai.moduleName);

                    if (ai.isActive) {

                        if (activePackagesSet.contains(packageInfo.packageName)) {
@@ -1140,7 +1133,7 @@ public abstract class ApexManager { 
        }



        @Override

        public List<ApexSystemServiceInfo> getApexSystemServices() {

        public Map<String, String> getApexSystemServices() {

            synchronized (mLock) {

                Preconditions.checkState(mApexSystemServices != null,

                        "APEX packages have not been scanned");
@@ -1430,10 +1423,10 @@ public abstract class ApexManager { 
        }



        @Override

        public List<ApexSystemServiceInfo> getApexSystemServices() {

        public Map<String, String> getApexSystemServices() {

            // TODO(satayev): we can't really support flattened apex use case, and need to migrate

            // the manifest entries into system's manifest asap.

            return Collections.emptyList();

            return Collections.emptyMap();

        }



        @Override

services/core/java/com/android/server/pm/ApexSystemServiceInfo.java

deleted100644 → 0
+0 −58
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2022 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package com.android.server.pm;



import android.annotation.Nullable;



/**

 * A helper class that contains information about apex-system-service to be used within system

 * server process.

 */

public final class ApexSystemServiceInfo implements Comparable<ApexSystemServiceInfo> {



    final String mName;

    @Nullable

    final String mJarPath;

    final int mInitOrder;



    public ApexSystemServiceInfo(String name, String jarPath, int initOrder) {

        this.mName = name;

        this.mJarPath = jarPath;

        this.mInitOrder = initOrder;

    }



    public String getName() {

        return mName;

    }



    public String getJarPath() {

        return mJarPath;

    }



    public int getInitOrder() {

        return mInitOrder;

    }



    @Override

    public int compareTo(ApexSystemServiceInfo other) {

        if (mInitOrder == other.mInitOrder) {

            return mName.compareTo(other.mName);

        }

        // higher initOrder values take precedence

        return -Integer.compare(mInitOrder, other.mInitOrder);

    }

}

services/core/java/com/android/server/pm/pkg/component/ParsedApexSystemService.java

+0 −3
Original line number Diff line number Diff line
@@ -34,7 +34,4 @@ public interface ParsedApexSystemService { 


    @Nullable

    String getMaxSdkVersion();



    int getInitOrder();



}

services/core/java/com/android/server/pm/pkg/component/ParsedApexSystemServiceImpl.java

+7 −23
Original line number Diff line number Diff line
@@ -48,18 +48,18 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
    @Nullable

    private String maxSdkVersion;



    private int initOrder;



    public ParsedApexSystemServiceImpl() {

    }







    // Code below generated by codegen v1.0.23.

    //

    // DO NOT MODIFY!

    // CHECKSTYLE:OFF Generated code

    //

    // To regenerate run:

    // $ codegen $ANDROID_BUILD_TOP/frameworks/base/services/core/java/com/android/server/pm/pkg/component/ParsedApexSystemServiceImpl.java

    // $ codegen $ANDROID_BUILD_TOP/frameworks/base/core/java/android/content/pm/parsing/component/ParsedApexSystemServiceImpl.java

    //

    // To exclude the generated code from IntelliJ auto-formatting enable (one-time):

    //   Settings > Editor > Code Style > Formatter Control
@@ -71,15 +71,13 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
            @NonNull String name,

            @Nullable String jarPath,

            @Nullable String minSdkVersion,

            @Nullable String maxSdkVersion,

            int initOrder) {

            @Nullable String maxSdkVersion) {

        this.name = name;

        com.android.internal.util.AnnotationValidations.validate(

                NonNull.class, null, name);

        this.jarPath = jarPath;

        this.minSdkVersion = minSdkVersion;

        this.maxSdkVersion = maxSdkVersion;

        this.initOrder = initOrder;



        // onConstructed(); // You can define this method to get a callback

    }
@@ -104,11 +102,6 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
        return maxSdkVersion;

    }



    @DataClass.Generated.Member

    public int getInitOrder() {

        return initOrder;

    }



    @DataClass.Generated.Member

    public @NonNull ParsedApexSystemServiceImpl setName(@NonNull String value) {

        name = value;
@@ -135,12 +128,6 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
        return this;

    }



    @DataClass.Generated.Member

    public @NonNull ParsedApexSystemServiceImpl setInitOrder( int value) {

        initOrder = value;

        return this;

    }



    @DataClass.Generated.Member

    static Parcelling<String> sParcellingForName =

            Parcelling.Cache.get(
@@ -200,7 +187,6 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
        sParcellingForJarPath.parcel(jarPath, dest, flags);

        sParcellingForMinSdkVersion.parcel(minSdkVersion, dest, flags);

        sParcellingForMaxSdkVersion.parcel(maxSdkVersion, dest, flags);

        dest.writeInt(initOrder);

    }



    @Override
@@ -219,7 +205,6 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
        String _jarPath = sParcellingForJarPath.unparcel(in);

        String _minSdkVersion = sParcellingForMinSdkVersion.unparcel(in);

        String _maxSdkVersion = sParcellingForMaxSdkVersion.unparcel(in);

        int _initOrder = in.readInt();



        this.name = _name;

        com.android.internal.util.AnnotationValidations.validate(
@@ -227,7 +212,6 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
        this.jarPath = _jarPath;

        this.minSdkVersion = _minSdkVersion;

        this.maxSdkVersion = _maxSdkVersion;

        this.initOrder = _initOrder;



        // onConstructed(); // You can define this method to get a callback

    }
@@ -247,10 +231,10 @@ public class ParsedApexSystemServiceImpl implements ParsedApexSystemService, Par 
    };



    @DataClass.Generated(

            time = 1643723578605L,

            time = 1641431950080L,

            codegenVersion = "1.0.23",

            sourceFile = "frameworks/base/services/core/java/com/android/server/pm/pkg/component/ParsedApexSystemServiceImpl.java",

            inputSignatures = "private @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.NonNull java.lang.String name\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String jarPath\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String minSdkVersion\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String maxSdkVersion\nprivate  int initOrder\nclass ParsedApexSystemServiceImpl extends java.lang.Object implements [com.android.server.pm.pkg.component.ParsedApexSystemService, android.os.Parcelable]\n@com.android.internal.util.DataClass(genGetters=true, genAidl=false, genSetters=true, genParcelable=true)")

            sourceFile = "frameworks/base/core/java/android/content/pm/parsing/component/ParsedApexSystemServiceImpl.java",

            inputSignatures = "private @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.NonNull java.lang.String name\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String jarPath\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String minSdkVersion\nprivate @com.android.internal.util.DataClass.ParcelWith(com.android.internal.util.Parcelling.BuiltIn.ForInternedString.class) @android.annotation.Nullable java.lang.String maxSdkVersion\nclass ParsedApexSystemServiceImpl extends java.lang.Object implements [android.content.pm.parsing.component.ParsedApexSystemService, android.os.Parcelable]\n@com.android.internal.util.DataClass(genGetters=true, genAidl=false, genSetters=true, genParcelable=true)")

    @Deprecated

    private void __metadata() {}