Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff22462b authored by Steven Moreland's avatar Steven Moreland
Browse files

Zero hidl-generated structs (bufferpool) 

Bug: 131356202
Test: boot
Change-Id: Icc42b852795ac2f151d552dd245bf7f432a2c6b2
parent ab09f6e6

media/bufferpool/1.0/Connection.cpp

+10 −2
Original line number Diff line number Diff line
@@ -32,14 +32,22 @@ Return<void> Connection::fetch(uint64_t transactionId, uint32_t bufferId, fetch_ 
            status = mAccessor->fetch(

                    mConnectionId, transactionId, bufferId, &handle);

            if (status == ResultStatus::OK) {

                _hidl_cb(status, Buffer{bufferId, handle});

                Buffer buffer = {};

                buffer.id = bufferId;

                buffer.buffer = handle;

                _hidl_cb(status, buffer);

                return Void();

            }

        } else {

            mAccessor->cleanUp(false);

        }

    }

    _hidl_cb(status, Buffer{0, nullptr});



    Buffer buffer = {};

    buffer.id = 0;

    buffer.buffer = nullptr;



    _hidl_cb(status, buffer);

    return Void();

}

media/bufferpool/2.0/Connection.cpp

+10 −2
Original line number Diff line number Diff line
@@ -32,14 +32,22 @@ Return<void> Connection::fetch(uint64_t transactionId, uint32_t bufferId, fetch_ 
            status = mAccessor->fetch(

                    mConnectionId, transactionId, bufferId, &handle);

            if (status == ResultStatus::OK) {

                _hidl_cb(status, Buffer{bufferId, handle});

                Buffer buffer = {};

                buffer.id = bufferId;

                buffer.buffer = handle;

                _hidl_cb(status, buffer);

                return Void();

            }

        } else {

            mAccessor->cleanUp(false);

        }

    }

    _hidl_cb(status, Buffer{0, nullptr});



    Buffer buffer = {};

    buffer.id = 0;

    buffer.buffer = nullptr;



    _hidl_cb(status, buffer);

    return Void();

}