Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fed6292a authored by Jean-Michel Trivi's avatar Jean-Michel Trivi
Browse files

Don't call audio effect process on offloaded playback threads 

An audio effect process command is not meant to be called for
 playback threads belonging to offloaded playback.

Bug 10933817

Change-Id: Idc7b6a0224791bbf8d61648474d3c288617c498f
parent d2ac3144

services/audioflinger/Effects.cpp

+4 −3
Original line number Diff line number Diff line
@@ -1279,9 +1279,10 @@ void AudioFlinger::EffectChain::process_l() 
    }

    bool isGlobalSession = (mSessionId == AUDIO_SESSION_OUTPUT_MIX) ||

            (mSessionId == AUDIO_SESSION_OUTPUT_STAGE);

    // always process effects unless no more tracks are on the session and the effect tail

    // has been rendered

    bool doProcess = true;

    // never process effects when:

    // - on an OFFLOAD thread

    // - no more tracks are on the session and the effect tail has been rendered

    bool doProcess = (thread->type() != ThreadBase::OFFLOAD);

    if (!isGlobalSession) {

        bool tracksOnSession = (trackCnt() != 0);