Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd36dc6d authored by Arun Johnson's avatar Arun Johnson
Browse files

Remove YV410 interpretation of RGBA_1010102 buffers 

Removes setting of flags used for interpreting
RGBA_1010102 buffers using HLG/PQ transfer funtion to Y410
in stagefright.

Bug: 265274023
Change-Id: I7787dc01d4c8609fd9f3da16558706d8814eb0a6
parent 1dbbf67c

media/codec2/hal/plugin/samples/SampleFilterPlugin.cpp

+0 −4
Original line number Diff line number Diff line
@@ -710,10 +710,6 @@ private: 
                layerSettings.source.buffer.fence = Fence::NO_FENCE;

                layerSettings.source.buffer.textureName = textureName;

                layerSettings.source.buffer.usePremultipliedAlpha = false;

                layerSettings.source.buffer.isY410BT2020 =

                    (layerSettings.sourceDataspace == ui::Dataspace::BT2020_ITU_PQ ||

                     layerSettings.sourceDataspace == ui::Dataspace::BT2020_ITU_HLG) &&

                    format == HAL_PIXEL_FORMAT_RGBA_1010102;

                layerSettings.source.buffer.maxMasteringLuminance =

                    (hdrStaticInfo && *hdrStaticInfo &&

                     hdrStaticInfo->mastering.maxLuminance > 0 &&

media/libstagefright/FrameCaptureLayer.cpp

+0 −9
Original line number Diff line number Diff line
@@ -64,14 +64,6 @@ ui::Dataspace translateDataspace(ui::Dataspace dataspace) { 
    return updatedDataspace;

}



bool isHdrY410(const BufferItem &bi) {

    ui::Dataspace dataspace = translateDataspace(static_cast<ui::Dataspace>(bi.mDataSpace));

    // pixel format is HDR Y410 masquerading as RGBA_1010102

    return ((dataspace == ui::Dataspace::BT2020_ITU_PQ ||

            dataspace == ui::Dataspace::BT2020_ITU_HLG) &&

            bi.mGraphicBuffer->getPixelFormat() == HAL_PIXEL_FORMAT_RGBA_1010102);

}



struct FrameCaptureLayer::BufferLayer : public FrameCaptureProcessor::Layer {

    BufferLayer(const BufferItem &bi) : mBufferItem(bi) {}

    void getLayerSettings(
@@ -95,7 +87,6 @@ void FrameCaptureLayer::BufferLayer::getLayerSettings( 
    layerSettings->source.buffer.fence = mBufferItem.mFence;

    layerSettings->source.buffer.textureName = textureName;

    layerSettings->source.buffer.usePremultipliedAlpha = false;

    layerSettings->source.buffer.isY410BT2020 = isHdrY410(mBufferItem);

    bool hasSmpte2086 = mBufferItem.mHdrMetadata.validTypes & HdrMetadata::SMPTE2086;

    bool hasCta861_3 = mBufferItem.mHdrMetadata.validTypes & HdrMetadata::CTA861_3;

    layerSettings->source.buffer.maxMasteringLuminance = hasSmpte2086