Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc97c43c authored by Wei Jia's avatar Wei Jia Committed by android-build-merger
Browse files

Merge "m4v_h263: check header first before decoding a frame." into lmp-dev am: 6aed93d5

am: 8772f84f

Change-Id: Iba4acd8b582f0cada22685b0dd5abd26a8c1ccde
parents 2675f4ca 8772f84f
Loading
Loading
Loading
Loading
+19 −4
Original line number Original line Diff line number Diff line
@@ -248,13 +248,28 @@ void SoftMPEG4::onQueueFilled(OMX_U32 /* portIndex */) {
            mSignalledError = true;
            mSignalledError = true;
            return;
            return;
        }
        }

        // Need to check if header contains new info, e.g., width/height, etc.
        VopHeaderInfo header_info;
        uint8_t *bitstreamTmp = bitstream;
        if (PVDecodeVopHeader(
                    mHandle, &bitstreamTmp, &timestamp, &tmp,
                    &header_info, &useExtTimestamp,
                    outHeader->pBuffer) != PV_TRUE) {
            ALOGE("failed to decode vop header.");

            notify(OMX_EventError, OMX_ErrorUndefined, 0, NULL);
            mSignalledError = true;
            return;
        }
        if (handlePortSettingsChange()) {
            return;
        }

        // The PV decoder is lying to us, sometimes it'll claim to only have
        // The PV decoder is lying to us, sometimes it'll claim to only have
        // consumed a subset of the buffer when it clearly consumed all of it.
        // consumed a subset of the buffer when it clearly consumed all of it.
        // ignore whatever it says...
        // ignore whatever it says...
        if (PVDecodeVideoFrame(
        if (PVDecodeVopBody(mHandle, &tmp) != PV_TRUE) {
                    mHandle, &bitstream, &timestamp, &tmp,
                    &useExtTimestamp,
                    outHeader->pBuffer) != PV_TRUE) {
            ALOGE("failed to decode video frame.");
            ALOGE("failed to decode video frame.");


            notify(OMX_EventError, OMX_ErrorUndefined, 0, NULL);
            notify(OMX_EventError, OMX_ErrorUndefined, 0, NULL);